[hazelcast-cpp-client] Add new port #16235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-client) port for Hazelcast in-memory database.
|
|
ihsandemir
force-pushed
the
hazelcast-cpp-client
branch
from
f6c4215
to
52229c4
Compare
NancyLi1013
added
the
category:new-port
NancyLi1013
changed the title
|
The regressions caused by gsoap should be fixed by PR #16270. |
ihsandemir
force-pushed
the
hazelcast-cpp-client
branch
from
22b7b63
to
9248291
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
suggested changes
Feb 19, 2021
ras0219-msft
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Since the changes have been merged upstream with very few intermediate commits, I think it'd be better for us to pull that commit directly instead of checking in a very large patch file to the vcpkg repo.
I've pushed that change, along with switching the versioning scheme to semver, enabling https://devblogs.microsoft.com/cppblog/take-control-of-your-vcpkg-dependencies-with-versioning-support/ :)
Thanks for the PR!
NancyLi1013
approved these changes
Feb 20, 2021
…x-add-version --overwrite-version hazelcast-cpp-client`.
|
LGTM now, thanks for adding this port. |
|
@NancyLi1013 @ras0219-msft Do you know who can merge the PR? |
|
Could you please help merge this PR? |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Hazelcast C++ client (https://github.com/hazelcast/hazelcast-cpp-client) port for Hazelcast in-memory database.
Which triplets are supported/not supported? Have you updated the CI baseline?
It should support all triplets.
Does your PR follow the maintainer guide?
Yes