Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-cmake] Fix typo in vcpkg_cmake_configure that prevented custom triplets from working #16468

Merged
merged 4 commits into from Mar 1, 2021
Merged

[vcpkg-cmake] Fix typo in vcpkg_cmake_configure that prevented custom triplets from working #16468

merged 4 commits into from Mar 1, 2021

Conversation

sylveon
Copy link
Contributor

@sylveon sylveon commented Mar 1, 2021

Describe the pull request

  • What does your PR fix? A typo that prevents triplets overriding release build flags from working.

  • Which triplets are supported/not supported? Have you updated the CI baseline? Yes

  • Does your PR follow the maintainer guide? Yes

@PhoebeHui PhoebeHui changed the title Fix typo in vcpkg_cmake_configure that prevented custom triplets from working [vcpkg] Fix typo in vcpkg_cmake_configure that prevented custom triplets from working Mar 1, 2021
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Mar 1, 2021
PhoebeHui
PhoebeHui approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui removed the category:port-bug The issue is with a library, which is something the port should already support label Mar 1, 2021
@PhoebeHui PhoebeHui changed the title [vcpkg] Fix typo in vcpkg_cmake_configure that prevented custom triplets from working [vcpkg-cmake] Fix typo in vcpkg_cmake_configure that prevented custom triplets from working Mar 1, 2021
@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Mar 1, 2021
@strega-nil strega-nil merged commit 94db0dc into microsoft:master Mar 1, 2021
@strega-nil
Copy link
Contributor

Thanks @sylveon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sylveon @strega-nil @ras0219 @PhoebeHui