Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_fixup_cmake_targets] Fix up OSX system development path #16706

Closed
wants to merge 24 commits into from
Closed

[vcpkg_fixup_cmake_targets] Fix up OSX system development path #16706

wants to merge 24 commits into from

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Mar 15, 2021 •
edited
Loading

In OSX, some cmake configuration files contain the absolute path of the system development kits, such as:

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/IOKit.framework

\$<\$<PLATFORM_ID:Darwin>:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreFoundation.framework>

And they should be:

-framework IOKit

\$<\$<PLATFORM_ID:Darwin>:-framework CoreFoundation>

Fix this.

Fixes #16259.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Mar 15, 2021
@JackBoosY
Copy link
Contributor Author

@davidebeatrici Can you please test this PR?

Thanks.

@davidebeatrici
Copy link
Contributor

Sorry for the delay.

The issue was fixed for abslTargets.cmake, but not for unofficial-angle-config.cmake:

set_target_properties(unofficial::angle::angle_gpu_info_util PROPERTIES
  INTERFACE_LINK_LIBRARIES "/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/IOKit.framework;/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreFoundation.framework;/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreGraphics.framework;\$<LINK_ONLY:unofficial::angle::angle_common>"
)

@JackBoosY
Copy link
Contributor Author

@davidebeatrici Should be good now.

@JackBoosY
Copy link
Contributor Author

Need wait for #16837 merge first.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 23, 2021
@davidebeatrici
Copy link
Contributor

I confirm it's fixed.

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 26, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 6, 2021
Merged
Merged
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Apr 14, 2021 •
edited
Loading

paraview:x64-osx:

CMake Error in Remoting/Views/CMakeLists.txt:
  Imported target "VTK::opengl" includes non-existent path

    "-framework OpenGL"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

INTERFACE_INCLUDE_DIRECTORIES "/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/OpenGL.framework"

@dg0yt dg0yt mentioned this pull request May 16, 2021
Merged
@JackBoosY
Copy link
Contributor Author 

CMake Error at scripts/cmake/vcpkg_configure_cmake.cmake:72 (message):
  The tensorpipe port already depends on vcpkg-cmake; using both vcpkg-cmake
  and vcpkg_configure_cmake in the same port is unsupported.
Call Stack (most recent call first):
  scripts/cmake/vcpkg_internal_get_cmake_vars.cmake:49 (vcpkg_configure_cmake)
  /Users/vagrant/Data/installed/x64-osx/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake:245 (vcpkg_internal_get_cmake_vars)
  ports/tensorpipe/portfile.cmake:40 (vcpkg_cmake_config_fixup)
  scripts/ports.cmake:139 (include)

Should fix this first.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 16, 2021
@dg0yt dg0yt mentioned this pull request Jul 6, 2021
Closed
@strega-nil strega-nil mentioned this pull request Jul 6, 2021
Closed
@JackBoosY
Copy link
Contributor Author

@strega-nil-ms Which rollup will contains this PR's changes?

@strega-nil-ms
Copy link
Contributor

@JackBoosY oops, it's gotta be marked or I'll miss; marking now.

@strega-nil-ms strega-nil-ms mentioned this pull request Aug 9, 2021
Merged
@strega-nil-ms
Copy link
Contributor

Closed for rollup #19469.

strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Aug 11, 2021
@strega-nil
[rollup:2021-08-09] PR microsoft#16706 (@JackBoosY)
c145cbc 
[vcpkg_fixup_cmake_targets] Fix up OSX system development path
strega-nil-ms added a commit that referenced this pull request Aug 16, 2021
@strega-nil-ms @strega-nil
@JackBoosY @BillyONeal
[rollup:2021-08-09] Rollup PR (#19469)
99e06a6 
* [rollup:2021-08-09] PR #16706 (@JackBoosY)

[vcpkg_fixup_cmake_targets] Fix up OSX system development path

* [rollup:2021-08-09] PR #19238 (@strega-nil)

[scripts-audit] vcpkg_download_distfile

* [rollup:2021-08-09] PR #19239 (@strega-nil)

[scripts-audit] vcpkg_find_fortran

* [rollup:2021-08-09] PR #19338 (@strega-nil)

[tinyfiledialogs] Fix for good

* [rollup:2021-08-09] PR #19348 (@strega-nil)

[scripts-audit] vcpkg_fixup_pkgconfig

* fix ports.cmake with newer vcpkg_download_distfile

* fix vcpkg create

* move vcpkg_common_definitions down so that it's not incorrect

* fix vcpkg_internal_get_cmake_vars

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
@aizuon aizuon mentioned this pull request Aug 19, 2021
Closed
@JackBoosY JackBoosY deleted the dev/jack/16259 branch May 26, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil left review comments

@dg0yt dg0yt dg0yt left review comments

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:different-pr This PR or Issue depends on a PR which has been filed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[macOS] Some ports reference hardcoded library paths
6 participants
@JackBoosY @davidebeatrici @strega-nil-ms @strega-nil @dg0yt @PhoebeHui