Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libxml2] Disable http and ftp on UWP #16726

Merged
merged 5 commits into from
Mar 22, 2021
Merged

[libxml2] Disable http and ftp on UWP #16726

merged 5 commits into from
Mar 22, 2021

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Mar 16, 2021 •
edited
Loading

Since libxml2 calls some Windows APIs that cannot be used in uwp, disable HTTP and FTP on UWP.

Compiler errors:

Unable to activate Windows Store app '1a2ed2c1-b8c3-4a00-ab03-f5d6312dc55e_kmdshx21vdgze!App'. 
The App5.exe process started, but the activation request failed with error 'The target process aborted before activation completed. 
More information may be available in the Debug pane of the Output window (Debug->Windows->Output)'.

Fixes #16529.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 16, 2021
@JackBoosY
Copy link
Contributor Author

Hi @ras0219-msft, does my changes met you requires?

@JackBoosY
Copy link
Contributor Author

Already report this issue to the upstream: https://gitlab.gnome.org/GNOME/libxml2/-/issues/225.

@JackBoosY JackBoosY marked this pull request as draft March 16, 2021 15:03
@JackBoosY JackBoosY marked this pull request as ready for review March 16, 2021 15:09
@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Mar 17, 2021
ras0219-msft
ras0219-msft approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM -- @HppZ does this fix your issue?

@JackBoosY JackBoosY removed the depends:upstream-changes Waiting on a change to the upstream project label Mar 18, 2021
@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

The upstream approved this changes, and the author response me: solved.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 21, 2021
@ras0219-msft ras0219-msft merged commit 00150f5 into microsoft:master Mar 22, 2021
@JackBoosY JackBoosY deleted the dev/jack/16529 branch March 23, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uwp app using libxml2 can't launch.
3 participants
@JackBoosY @ras0219-msft @NancyLi1013