[collada-dom] Add REMOVE_RECURSE to solve DLLs error path #16763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
category:port-bug
NancyLi1013
suggested changes
Mar 18, 2021
NancyLi1013
suggested changes
Mar 18, 2021
NancyLi1013
approved these changes
Mar 18, 2021
ras0219-msft
requested changes
Mar 18, 2021
There was a problem hiding this comment.
collada-dom only supports shared library linkage: https://github.com/rdiankov/collada-dom/blob/master/dom/CMakeLists.txt#L31.
We either need to patch out the SHARED keyword from the add_library() call or we need to add vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY) at the top of this port.
NancyLi1013
removed
the
info:reviewed
NancyLi1013
approved these changes
Mar 19, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
When install colladda-dom:x64-windows-static ，The error shows that DLL files are generated in the bin directory during static install, use REMOVE_RECURSE in the portfile to remove them,
Note: no feature need to test