Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg/scripts] add variable VCPKG_CROSSCOMPILING #16900

Merged
merged 5 commits into from Apr 2, 2021
Merged

[vcpkg/scripts] add variable VCPKG_CROSSCOMPILING #16900

merged 5 commits into from Apr 2, 2021

Conversation

Neumann-A
Copy link
Contributor

No description provided.

@PhoebeHui PhoebeHui added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Mar 26, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 30, 2021
@JackBoosY
Copy link
Contributor

LGTM.

strega-nil
strega-nil suggested changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable should be called "VCPKG_IS_CROSSCOMPILING"

scripts/cmake/vcpkg_common_definitions.cmake Outdated Show resolved Hide resolved
scripts/cmake/vcpkg_common_definitions.cmake Outdated Show resolved Hide resolved
@strega-nil
Copy link
Contributor

Marking requires:discussion since this is an auto-stable new name.

@strega-nil
Copy link
Contributor

@Neumann-A please merge the changes; VCPKG_CROSSCOMPILING has been agreed upon (2F, 1A)

@Neumann-A @strega-nil
Apply suggestions from code review
086bd5c 
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@Neumann-A
Copy link
Contributor Author

@strega-nil done

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft ras0219-msft merged commit 42c437b into microsoft:master Apr 2, 2021
@ras0219-msft
Copy link
Contributor

Thanks!

@autoantwort autoantwort mentioned this pull request Apr 3, 2021
Merged
@Neumann-A Neumann-A deleted the add_vcpkg_crosscompiling branch April 7, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autoantwort autoantwort autoantwort left review comments

@strega-nil strega-nil strega-nil approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Neumann-A @JackBoosY @strega-nil @ras0219-msft @autoantwort @PhoebeHui