Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Libidn2] disable documentation #17419

Merged
merged 11 commits into from
Apr 25, 2021
Merged

[Libidn2] disable documentation #17419

merged 11 commits into from
Apr 25, 2021

Conversation

xandox
Copy link
Contributor

@xandox xandox commented Apr 21, 2021

Documentation generates by gtk tool which not must exists. For PR #15605

  • Which triplets are supported/not supported? Have you updated the CI baseline?

same, No

yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@dg0yt
Copy link
Contributor

dg0yt commented Apr 21, 2021

Same as for #17420 (comment)

@xandox
Copy link
Contributor Author

xandox commented Apr 21, 2021

gt-html is on by default according to configure --help

@NancyLi1013 NancyLi1013 self-assigned this Apr 22, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 22, 2021
NancyLi1013
NancyLi1013 suggested changes Apr 22, 2021
View reviewed changes
ports/libidn2/vcpkg.json Outdated Show resolved Hide resolved
@xandox xandox requested a review from NancyLi1013 April 22, 2021 10:38
@dg0yt
Copy link
Contributor

dg0yt commented Apr 22, 2021

osx: #17057 reproduced.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 23, 2021

The autoreconf patch will probaly fix the build, but it is tightly coupled to the current source files.

In the meantime, I could verify that my proposal from #17420 (comment) works. So alternative to patching, it can be solved just by configuration if you take our pieces together:

set(ENV{GTKDOCIZE} true)
...
   --disable-gtk-doc...

@xandox
Copy link
Contributor Author

xandox commented Apr 23, 2021

I do not known what is wrong with getdns. It's perfectly builds on my host.

@xandox
Copy link
Contributor Author

xandox commented Apr 23, 2021

@dg0yt thank you. Your suggestion better.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 23, 2021

do not known what is wrong with getdns.

I don't think it is related to the doc changes here. This PR just triggers the rebuild.

@dg0yt thank you. Your suggestion better.

Thanks for integrating my suggestion.

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ras0219-msft
ras0219-msft approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement!

This was referenced Apr 24, 2021
Closed
Closed
Closed
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 24, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Apr 25, 2021
Merged
@BillyONeal BillyONeal merged commit 84e5852 into microsoft:master Apr 25, 2021
@dg0yt dg0yt mentioned this pull request Apr 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xandox @dg0yt @ras0219-msft @NancyLi1013 @BillyONeal @JackBoosY