-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oatpp] update to 1.2.5 #17601
[oatpp] update to 1.2.5 #17601
Conversation
@autoantwort ,Thanks for your pr,according to the error display of CI, the components port of oatpp also needs to be upgraded along with oatpp. could you upgrade all components together in one pr? |
I have the feeling that this release breaks more than it fixes :D |
Finally the build is successful |
@autoantwort Are you finding any breakages other than Windows build? I opened the original issue #17504 because I am trying to troubleshoot oatpp/oatpp-openssl#7, which should be fixed in 1.2.5. |
Yeah I was only referring to the windows builds that needed some patches. |
Thanks a lot for getting it to build @autoantwort |
@autoantwort ,Thanks for your contribution 👍 |
Describe the pull request
What does your PR fix?
Fixes [oatpp] update to 1.2.5 #17599
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes