Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oatpp] update to 1.2.5 #17601

Merged
merged 12 commits into from
May 18, 2021
Merged

[oatpp] update to 1.2.5 #17601

merged 12 commits into from
May 18, 2021

Conversation

autoantwort
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes [oatpp] update to 1.2.5 #17599

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@autoantwort autoantwort marked this pull request as draft May 1, 2021 11:54
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label May 2, 2021
@JonLiu1993
Copy link
Member

@autoantwort ,Thanks for your pr,according to the error display of CI, the components port of oatpp also needs to be upgraded along with oatpp. could you upgrade all components together in one pr?

@autoantwort autoantwort marked this pull request as ready for review May 10, 2021 13:22
@autoantwort
Copy link
Contributor Author

I have the feeling that this release breaks more than it fixes :D

@autoantwort
Copy link
Contributor Author

Finally the build is successful

@xanderdunn
Copy link

@autoantwort Are you finding any breakages other than Windows build? I opened the original issue #17504 because I am trying to troubleshoot oatpp/oatpp-openssl#7, which should be fixed in 1.2.5.

@autoantwort
Copy link
Contributor Author

@autoantwort Are you finding any breakages other than Windows build? I opened the original issue #17504 because I am trying to troubleshoot oatpp/oatpp-openssl#7, which should be fixed in 1.2.5.

Yeah I was only referring to the windows builds that needed some patches.

@xanderdunn
Copy link

Thanks a lot for getting it to build @autoantwort

@JonLiu1993
Copy link
Member

@autoantwort ,Thanks for your contribution 👍

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2021
@dan-shaw dan-shaw merged commit fe6e4b7 into microsoft:master May 18, 2021
@autoantwort autoantwort deleted the update-oatpp branch September 1, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[oatpp] update to 1.2.5
5 participants