Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][libmicrohttpd] Control dependencies, doc, examples, test #17653

Merged
merged 7 commits into from
May 18, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented May 4, 2021

  • What does your PR fix?

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    unchanged, no
    Note that CI baseline contains: libmicrohttpd:x64-windows-static-md=fail

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

CC @NancyLi1013

@dg0yt
Copy link
Contributor Author

dg0yt commented May 4, 2021

PS: A https feature might be added later, even for Windows (https://stackoverflow.com/questions/39928579/libmicrohttpd-and-ssl). Note that this feature limits licensing to "LGPL". Without https, licensing is "LGPL or eCos".

@dg0yt
Copy link
Contributor Author

dg0yt commented May 4, 2021

Converted version-string to version now.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels May 5, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 7, 2021
@NancyLi1013
Copy link
Contributor

LGTM, thanks for your PR @dg0yt.

@JackBoosY JackBoosY changed the title [libmicrohttpd] Control dependencies, doc, examples, test [vcpkg baseline][libmicrohttpd] Control dependencies, doc, examples, test May 13, 2021
@JackBoosY
Copy link
Contributor

Ping @dan-shaw @strega-nil-ms for review and merge this PR first.

@dg0yt
Copy link
Contributor Author

dg0yt commented May 13, 2021

FTR, I also noticed a missing vcpkg_fixup_pkgconfig. The prefix is the installed dir, absolutely.
However, I cannot add the missing call before #17898 is merged.

@JackBoosY
Copy link
Contributor

@dg0yt It doesn't matter, we can add it in other PRs

@dg0yt
Copy link
Contributor Author

dg0yt commented May 18, 2021

Reminder: The microhttpd build issue affects all changes to vcpkg_configure_make on osx. And these CI runs are expensive.

@dan-shaw dan-shaw merged commit 38e7e03 into microsoft:master May 18, 2021
@dg0yt dg0yt deleted the libmicrohttpd-patch branch May 27, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libmicrohttpd] Port doesn't declare its dependencies
4 participants