Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[czmq] Update to v4.2.1 #17989

Merged
merged 14 commits into from Jul 15, 2021
Merged

[czmq] Update to v4.2.1 #17989

merged 14 commits into from Jul 15, 2021

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented May 18, 2021

Describe the pull request

  • What does your PR fix?

    Fixes #...

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    <Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JonLiu1993 JonLiu1993 self-assigned this May 19, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 19, 2021
@JonLiu1993
Copy link
Member

@myd7349 Ready for review now?

@PhoebeHui
Copy link
Contributor

@myd7349, thanks for your contribution! ping us if the PR ready for review.

@JonLiu1993
Copy link
Member

@myd7349, thanks for your contribution! ping us if the PR ready for review.

1 similar comment
@JonLiu1993
Copy link
Member

@myd7349, thanks for your contribution! ping us if the PR ready for review.

@myd7349
Copy link
Contributor Author

myd7349 commented Jul 9, 2021

Hi! @JonLiu1993 @PhoebeHui Sorry for the long delay.
This PR is ready now. Please review, thanks.

@myd7349 myd7349 marked this pull request as ready for review July 9, 2021 10:08
JonLiu1993
JonLiu1993 requested changes Jul 12, 2021
View reviewed changes
ports/czmq/portfile.cmake
endif()
if(EXISTS ${CURRENT_PACKAGES_DIR}/share/cmake/${PORT})
vcpkg_fixup_cmake_targets(CONFIG_PATH share/cmake/${PORT})
vcpkg_cmake_config_fixup(CONFIG_PATH share/cmake/${PORT})
endif()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_fixup_pkgconfig()

ports/czmq/vcpkg.json Outdated
@@ -0,0 +1,53 @@
{
"name": "czmq",
"version": "4.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "4.2.1",
"version-semver": "4.2.1",

@JonLiu1993
Copy link
Member

@myd7349 ，
Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static？

@myd7349
Copy link
Contributor Author

myd7349 commented Jul 12, 2021

@myd7349 ，
Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static？

Hi! @JonLiu1993 Yes. I have tested the features locally.

@JonLiu1993
Copy link
Member

@myd7349 ，
Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static？

Hi! @JonLiu1993 Yes. I have tested the features locally.

Please complete the modification I requested and I can approve this pr

@myd7349
Copy link
Contributor Author

myd7349 commented Jul 13, 2021

@myd7349 ，
Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static？

Hi! @JonLiu1993 Yes. I have tested the features locally.

Please complete the modification I requested and I can approve this pr

Hi! @JonLiu1993 Thanks!

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 14, 2021
@BillyONeal BillyONeal merged commit 9624235 into microsoft:master Jul 15, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

@myd7349 myd7349 deleted the czmq-4.2.1 branch July 16, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@myd7349 @JonLiu1993 @PhoebeHui @BillyONeal