Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[highfive] Update to v2.3 #17990

Merged
merged 10 commits into from
Jun 9, 2021
Merged

[highfive] Update to v2.3 #17990

merged 10 commits into from
Jun 9, 2021

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented May 18, 2021

Describe the pull request

  • What does your PR fix?

    Fixes #...

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JonLiu1993 JonLiu1993 self-assigned this May 19, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 19, 2021
@JonLiu1993
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

JonLiu1993
JonLiu1993 reviewed May 19, 2021
View reviewed changes
Copy link
Member

@JonLiu1993 JonLiu1993 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change "file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/highfive RENAME copyright)" to "file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)" in the portifile.cmake

@PhoebeHui
Copy link
Contributor

@myd7349, thanks for your contribution! ping us if the PR ready for review.

@myd7349 myd7349 marked this pull request as ready for review June 5, 2021 02:44
@myd7349
Copy link
Contributor Author

myd7349 commented Jun 5, 2021

Hi! @JonLiu1993 @PhoebeHui Sorry for the long delay. I think I have finished this PR. Please review. Thanks.

@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jun 7, 2021
@JonLiu1993
Copy link
Member

JonLiu1993 commented Jun 7, 2021 •
edited
Loading

All features are tested successfully in the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jun 7, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @myd7349 :)

@strega-nil-ms strega-nil-ms merged commit be56553 into microsoft:master Jun 9, 2021
@myd7349 myd7349 deleted the highfive-v2.3 branch June 10, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@myd7349 @JonLiu1993 @PhoebeHui @strega-nil-ms