Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Add debug_message to vcpkg_configure_meson.cmake #18207

Merged
merged 3 commits into from Jul 15, 2021
Merged

[vcpkg] Add debug_message to vcpkg_configure_meson.cmake #18207

merged 3 commits into from Jul 15, 2021

Conversation

kafeg
Copy link
Contributor

@kafeg kafeg commented May 31, 2021

Just simplify debugging when you are working on any port depended on meson and Mac M1.

@PhoebeHui PhoebeHui self-assigned this Jun 1, 2021
@PhoebeHui PhoebeHui changed the title Add debug_message to vcpkg_configure_meson.cmake [vcpkg] Add debug_message to vcpkg_configure_meson.cmake Jun 1, 2021
@PhoebeHui PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jun 1, 2021
PhoebeHui
PhoebeHui approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

cc @Neumann-A

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 1, 2021
Deledrius
Deledrius reviewed Jun 6, 2021
View reviewed changes
Copy link
Contributor

@Deledrius Deledrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a bit more readable. The original is very difficult to parse in English.

scripts/cmake/vcpkg_configure_meson.cmake Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jun 7, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 16, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

@BillyONeal BillyONeal merged commit c8666b7 into microsoft:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deledrius Deledrius Deledrius left review comments

@Hoikas Hoikas Hoikas left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kafeg @BillyONeal @Deledrius @Hoikas @PhoebeHui