Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gamenetworkingsockets] update to 1.3.0 #18313

Merged
merged 4 commits into from
Jun 11, 2021
Merged

[gamenetworkingsockets] update to 1.3.0 #18313

merged 4 commits into from
Jun 11, 2021

Conversation

aizuon
Copy link
Contributor

@aizuon aizuon commented Jun 7, 2021

@JonLiu1993 JonLiu1993 self-assigned this Jun 8, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 8, 2021
JonLiu1993
JonLiu1993 requested changes Jun 8, 2021
View reviewed changes
ports/gamenetworkingsockets/vcpkg.json Outdated Show resolved Hide resolved
versions/g-/gamenetworkingsockets.json Outdated Show resolved Hide resolved
JonLiu1993
JonLiu1993 requested changes Jun 8, 2021
View reviewed changes
Copy link
Member

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "vcpkg_fixup_pkgconfig" below "vcpkg_fixup_cmake_targets" in portfile.cmake

@aizuon
Copy link
Contributor Author

aizuon commented Jun 8, 2021

Is the usage of vcpkg_fixup_pkgconfig correct without any arguments? I've checked the buildtrees of gamenetworkingsockets and couldn't find and .pc files.

@aizuon aizuon requested a review from JonLiu1993 June 8, 2021 10:10
@JonLiu1993
Copy link
Member

Is the usage of vcpkg_fixup_pkgconfig correct without any arguments? I've checked the buildtrees of gamenetworkingsockets and couldn't find and .pc files.

This is the official reference document of vcpkg_fixup_pkgconfig. You can refer to it. I found the .pc file in the buildtrees of gamenetworkingsockets before. I have re-run CI, and I will check it again after running.

@JonLiu1993
Copy link
Member

Is the usage of vcpkg_fixup_pkgconfig correct without any arguments? I've checked the buildtrees of gamenetworkingsockets and couldn't find and .pc files.

This is the official reference document of vcpkg_fixup_pkgconfig. You can refer to it. I found the .pc file in the buildtrees of gamenetworkingsockets before. I have re-run CI, and I will check it again after running.

After rerun, I also tested locally and did not find the .pc file, the files below it are all correct

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 10, 2021
@strega-nil-ms
Copy link
Contributor

Cool, thanks @aizuon!

@strega-nil-ms strega-nil-ms merged commit cdbbbf4 into microsoft:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gamenetworkingsockets] update to 1.3.0
3 participants
@aizuon @JonLiu1993 @strega-nil-ms