Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hazelcast-cpp-client] update to v4.1.1 #18318

Merged
merged 2 commits into from
Jun 11, 2021
Merged

[hazelcast-cpp-client] update to v4.1.1 #18318

merged 2 commits into from
Jun 11, 2021

Conversation

yemreinci
Copy link
Contributor

  • What does your PR fix?

    Updates port hazelcast-cpp-client to the latest version, fixes deprecated use of vcpkg_check_features in the port file.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Same as before, all except uwp triplets. No need to update the CI baseline.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@ghost
Copy link

ghost commented Jun 7, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@yemreinci yemreinci marked this pull request as ready for review June 7, 2021 18:54
@JonLiu1993 JonLiu1993 self-assigned this Jun 8, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 8, 2021
@JonLiu1993
Copy link
Member

@yemreinci ,Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static?

@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jun 8, 2021
@yemreinci
Copy link
Contributor Author

@yemreinci ,Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static?

Yes, I have. Features work for the supported triplets.

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jun 9, 2021
@strega-nil-ms strega-nil-ms merged commit d9538eb into microsoft:master Jun 11, 2021
@strega-nil-ms
Copy link
Contributor

thanks @yemreinci :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihsandemir ihsandemir ihsandemir approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yemreinci @JonLiu1993 @strega-nil-ms @ihsandemir