New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CGAL] Upgrade to 5.3 #18392
[CGAL] Upgrade to 5.3 #18392
Conversation
@maxGimeno ,Thanks for your contribution. |
@JonLiu1993 don't worry, it will stay a draft until the release of the CGAL 5.3 version, then I'll update the PR to the stable version and un-draft it. For now it was just to be sure that in the current state we can pass your CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add 'FEATURES' in function vcpkg_check_features like:
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
qt WITH_CGAL_Qt5
)
@maxGimeno ,After completing the modification, please run the command "./vcpkg x-add-version cgal --overwrite-version", and then submit the changes again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve merge conglicts, otherwise LGTM.
…' into CGAL-Upgrade_to_5.3-maxGimeno
Upgrade CGAL to version 5.3