[simdjson] Update to v0.9.6 #18479
Merged
[simdjson] Update to v0.9.6 #18479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:port-update
|
@myd7349 ,Please let me know if this pr is ready for review |
|
Hi! @JonLiu1993 Thanks for your helpful review and sorry for the long delay. @JonLiu1993 Most of options used in simdjson are defined in https://github.com/simdjson/simdjson/blob/v0.9.6/cmake/simdjson-flags.cmake. |
JonLiu1993
added
category:port-feature
|
@myd7349, have you tested these functions locally? |
Hi! @JonLiu1993 I have tested these features on:
and it worked as expected on all these platforms. My linux machine doesn't have a C++17 compiler, so I was not able to test them on |
JonLiu1993
approved these changes
Jul 14, 2021
JonLiu1993
added
info:reviewed
BillyONeal
requested changes
Jul 16, 2021
BillyONeal
added
requires:author-response
and removed
info:reviewed
Features need to be additive, not subtractive.
JonLiu1993
approved these changes
Jul 19, 2021
JonLiu1993
added
info:reviewed
BillyONeal
approved these changes
Jul 19, 2021
|
Fix #19009 |
|
Thanks for your contribution @myd7349 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?
<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?
Your answerIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?<Yes / I am still working on this PR>
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/