[openblas] Fix C/CXX flag customization in openblas #18535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
reviewed
Jun 19, 2021
JackBoosY
added
category:port-bug
JackBoosY
suggested changes
Jun 21, 2021
There was a problem hiding this comment.
Please bump the port version. See documentation.
Also please run command vcpkg x-add-version --all then commit the changes.
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
|
@JackBoosY Updated the versions. Thanks. |
JackBoosY
reviewed
Jun 21, 2021
JackBoosY
approved these changes
Jun 21, 2021
JackBoosY
changed the title
JackBoosY
added
info:reviewed
|
Can you please resolve the file conflict? Thanks. |
…joschonb/openblas-portfile-fix
|
@JackBoosY Done. Would appreciate to get this merged to avoid another conflict. Thanks! |
JackBoosY
reviewed
Jul 14, 2021
JackBoosY
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was broken when VCPKG_C_FLAGS or VCPKG_CXX_FLAGS were already defined in the triplet config file.