Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[laszip] Migrate LASzip to the new manifest format. #18614

Merged
merged 2 commits into from Jul 23, 2021
Merged

[laszip] Migrate LASzip to the new manifest format. #18614

merged 2 commits into from Jul 23, 2021

Conversation

CreMindES
Copy link
Contributor

Description

  • What does your PR fix?

    Migrate LASzip to the preferred manifest format.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

  • Note

    It also fixed an issue on Windows with MSVC where LASZIP_ROOT needed to be defined. With the new cmake configure and install functions this is no longer needed.

@ghost
Copy link

ghost commented Jun 23, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Jun 24, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 24, 2021
@JonLiu1993
Copy link
Member

@CreMindES ,Thanks for your pr .
We recommend waiting for the new version of LASzip to be released, and port optimization should be performed when upgrading the new version.

@CreMindES
Migrate LASzip to the new manifest format.
9f76507 
- CONTROL -> vcpkg.json
- vcpkg_configure_cmake -> vcpkg_cmake_configure
- vcpkg_install_cmake -> vcpkg_cmake_install
@CreMindES
Copy link
Contributor Author

@CreMindES ,Thanks for your pr .
We recommend waiting for the new version of LASzip to be released, and port optimization should be performed when upgrading the new version.

@JonLiu1993 Could you elaborate on the motivation behind that or point me to the a docs about it? I've looked but did not find much.
Side note: the last release date of LASzip is Nov 2019 ...

@JackBoosY
Copy link
Contributor

@CreMindES ,Thanks for your pr .
We recommend waiting for the new version of LASzip to be released, and port optimization should be performed when upgrading the new version.

@JonLiu1993 Could you elaborate on the motivation behind that or point me to the a docs about it? I've looked but did not find much.
Side note: the last release date of LASzip is Nov 2019 ...

See https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#avoid-trivial-changes-in-untouched-files.

It also fixed an issue on Windows with MSVC where LASZIP_ROOT needed to be defined. With the new cmake configure and install functions this is no longer needed.

I didn't find the related changes about this, can you confirm that?

@PhoebeHui PhoebeHui changed the title Migrate LASzip to the new manifest format. [laszip] Migrate LASzip to the new manifest format. Jul 20, 2021
PhoebeHui
PhoebeHui approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 20, 2021
@vicroms vicroms merged commit ef793cb into microsoft:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CreMindES @JonLiu1993 @JackBoosY @PhoebeHui @vicroms