Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-storage-cpp] Deprecate azure-storage-cpp package #18618

Merged
merged 9 commits into from Jul 23, 2021

Conversation

Jinming-Hu
Copy link
Contributor

@Jinming-Hu Jinming-Hu commented Jun 24, 2021

Hi, I'm developer of Azure Storage Client team. Since we've announced GA of our Track2 version of azure storage C++ sdk and it's now available on vcpkg, we'd like to deprecate the old azure-storage-cpp package.

Describe the pull request

  • What does your PR fix?

Deprecate a package.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all, yes

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

I didn't update any port.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JonLiu1993
Copy link
Member

@Jinming-Hu ,Please run command "./vcpkg x-add-version azure-storage-cpp --overwrite-version" then commit change again

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 2, 2021
@ras0219-msft
Copy link
Contributor

Perhaps we should also print a message at the top of the portfile instructing users to move to the new package?

message(WARNING "azure-storage-cpp is no longer actively developed. Instead, users should migrate to the new sdk: <???>")

@JonLiu1993 JonLiu1993 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jul 7, 2021
@PhoebeHui PhoebeHui changed the title Deprecate azure-storage-cpp package [azure-storage-cpp] Deprecate azure-storage-cpp package Jul 16, 2021
@JonLiu1993
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 19, 2021
@PhoebeHui PhoebeHui removed the info:reviewed Pull Request changes follow basic guidelines label Jul 19, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 20, 2021
@vicroms vicroms merged commit 25f4315 into microsoft:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants