New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffmpeg] Enable fdk on arm or uwp. #18659
Conversation
can you please add the feature as a default one in vcpkg-ci-ffmpeg also for these new valid configs, so that we test it automatically? |
Hi @Sibras Thanks for your PR. Have you tested these features |
we can test the feature in this way, but should not add it as a default one in master branch, except it's reasonable. |
The vcpkg-ci-ffmpeg already runs all-nonfree (which includes fdk) so it should be auto running the tests already.
As above the ci is already running tests with all dependencies enabled as part of all-nonfree (which includes fdk-aac) |
those are for CI only and are used for some specific ports to test as many features as possible, in order to ease review process and guarantee that dependencies are not going to break their non-default features |
Have found the build result on ci. Thanks @Sibras
|
Thanks for your contribution! |
Enables the use of fdk-aac when using arm or uwp as this is no longer required since fdk was updated to 2.0.2.