Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg] Enable fdk on arm or uwp. #18659

Merged
merged 6 commits into from Jul 15, 2021
Merged

[ffmpeg] Enable fdk on arm or uwp. #18659

merged 6 commits into from Jul 15, 2021

Conversation

Sibras
Copy link
Contributor

@Sibras Sibras commented Jun 26, 2021

Enables the use of fdk-aac when using arm or uwp as this is no longer required since fdk was updated to 2.0.2.

@cenit
Copy link
Contributor

cenit commented Jun 27, 2021

can you please add the feature as a default one in vcpkg-ci-ffmpeg also for these new valid configs, so that we test it automatically?

@NancyLi1013 NancyLi1013 self-assigned this Jun 28, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 28, 2021
@NancyLi1013
Copy link
Contributor

Hi @Sibras

Thanks for your PR.

Have you tested these features fdk-aac and all-nonfree on arm and uwp?

@NancyLi1013 NancyLi1013 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jun 28, 2021
@NancyLi1013
Copy link
Contributor

can you please add the feature as a default one in vcpkg-ci-ffmpeg also for these new valid configs, so that we test it automatically?

we can test the feature in this way, but should not add it as a default one in master branch, except it's reasonable.

@Sibras
Copy link
Contributor Author

Sibras commented Jun 28, 2021

can you please add the feature as a default one in vcpkg-ci-ffmpeg also for these new valid configs, so that we test it automatically?

The vcpkg-ci-ffmpeg already runs all-nonfree (which includes fdk) so it should be auto running the tests already.

Thanks for your PR.

Have you tested these features fdk-aac and all-nonfree on arm and uwp

As above the ci is already running tests with all dependencies enabled as part of all-nonfree (which includes fdk-aac)

@cenit
Copy link
Contributor

cenit commented Jun 28, 2021

we can test the feature in this way, but should not add it as a default one in master branch, except it's reasonable.

those are for CI only and are used for some specific ports to test as many features as possible, in order to ease review process and guarantee that dependencies are not going to break their non-default features

@NancyLi1013
Copy link
Contributor

Have found the build result on ci. Thanks @Sibras

Building package ffmpeg[all,all-gpl,all-nonfree,avcodec,avdevice,avfilter,avformat,avresample,bzip2,core,fdk-aac,freetype,gpl,iconv,lzma,mp3lame,nonfree,openjpeg,openssl,opus,postproc,sdl2,snappy,soxr,speex,swresample,swscale,theora,vorbis,vpx,webp,xml2,zlib]:arm-uwp... done
Installing package ffmpeg[all,all-gpl,all-nonfree,avcodec,avdevice,avfilter,avformat,avresample,bzip2,core,fdk-aac,freetype,gpl,iconv,lzma,mp3lame,nonfree,openjpeg,openssl,opus,postproc,sdl2,snappy,soxr,speex,swresample,swscale,theora,vorbis,vpx,webp,xml2,zlib]:arm-uwp...
Installing package ffmpeg[all,all-gpl,all-nonfree,avcodec,avdevice,avfilter,avformat,avresample,bzip2,core,fdk-aac,freetype,gpl,iconv,lzma,mp3lame,nonfree,openjpeg,openssl,opus,postproc,sdl2,snappy,soxr,speex,swresample,swscale,theora,vorbis,vpx,webp,xml2,zlib]:arm-uwp... done

@NancyLi1013 NancyLi1013 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jun 28, 2021
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jun 28, 2021

I have made sense why it will run all-nonfree in CI test and I'm also clear about vcpkg-ci-ffmpeg. Sorry for my mistake. Thanks @Sibras @cenit

Build-Depends: ffmpeg[all-nonfree]

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jun 28, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

@BillyONeal BillyONeal merged commit ee66b89 into microsoft:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants