Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[giflib] Update to 5.2.1 #18836

Merged
merged 9 commits into from Jul 23, 2021
Merged

[giflib] Update to 5.2.1 #18836

merged 9 commits into from Jul 23, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 6, 2021 •
edited

  • What does your PR fix?

    • Updates giflib to version 5.2.1.
    • Modernize portfile.
    • Disable GifDrawBoxedText8x8 on Windows (needs strtok_r).
    • Enables shared linkage.
      (Apart from general usefulness, it resolves libtool trouble for mingw-dynamic triplets e.g. when building gdal.)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@NancyLi1013 NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jul 7, 2021
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 7, 2021

Hm, so Windows has no strtok_r. But why doesn't it fail in static builds? If no one ever calls GifDrawBoxedText8x8, I better disable this function instead of adding a patch which I cannot test. (Windows' strtok_s might work as a replacement.) Opinions?

@dg0yt dg0yt marked this pull request as ready for review July 10, 2021 14:01
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 12, 2021
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jul 12, 2021 •
edited

LGTM, thanks for your updates. @dg0yt

ras0219-msft
ras0219-msft requested changes Jul 13, 2021
View reviewed changes
ports/giflib/fix-compile-error.patch Outdated Show resolved Hide resolved
ports/giflib/exports.def Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jul 14, 2021
@NancyLi1013 NancyLi1013 added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 20, 2021
@vicroms vicroms removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jul 22, 2021
@vicroms vicroms merged commit 635361d into microsoft:master Jul 23, 2021
@dg0yt dg0yt deleted the giflib branch July 29, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft requested changes

@vicroms vicroms vicroms approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dg0yt @NancyLi1013 @vicroms @ras0219-msft