Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ubuntu 20.04. #18892

Merged
merged 14 commits into from Jul 14, 2021
Merged

Update to Ubuntu 20.04. #18892

merged 14 commits into from Jul 14, 2021

Conversation

BillyONeal
Copy link
Member

Resolves #13624

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Jul 9, 2021
@Neumann-A
Copy link
Contributor

Could you add nodejs to the APT_PACKAGES. node is required to build qtwebengine in Qt 6.2.

@BillyONeal
Copy link
Member Author

Could you add nodejs to the APT_PACKAGES. node is required to build qtwebengine in Qt 6.2.

Done

@JackBoosY
Copy link
Contributor

Also please add libgtk-3-dev since #17111 need it.

@BillyONeal
Copy link
Member Author

Also please add libgtk-3-dev since #17111 need it.

If this one builds without errors I'll merge it, if not I'll immediately start another one adding that.

@BillyONeal
Copy link
Member Author

Also please add libgtk-3-dev since #17111 need it.

If this one builds without errors I'll merge it, if not I'll immediately start another one adding that.

I mean: If this one builds OK, I'll merge this one, and start a new one right after adding that for you. If this one doesn't build OK, I'll add it here.

@BillyONeal BillyONeal merged commit 957d202 into microsoft:master Jul 14, 2021
@BillyONeal BillyONeal deleted the ubuntu-update branch July 14, 2021 19:46
@BillyONeal
Copy link
Member Author

Also please add libgtk-3-dev since #17111 need it.

image

I'm not sure I should do that; it seems to be dragging in a bunch of libraries that are also in vcpkg and thus are likely to create ABI conflicts?

@dg0yt
Copy link
Contributor

dg0yt commented Jul 15, 2021

Also please add libgtk-3-dev since #17111 need it.

@ras0219-msft wrote that "100% we should not be using gtk3 from the system."

... it seems to be dragging in a bunch of libraries that are also in vcpkg and thus are likely to create ABI conflicts?

I proposed to add gtk-3, based on the last gtk port version that was based on gtk-3.
It might be enough to use it for wxwidgets/linux only.

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Jul 15, 2021

If a package depends on gtk 3, it is incompatible with the current vcpkg CI, same as if a package wants boringssl or libressl.

If we see enough need for gtk3, we can investigate other options like a separate CI pass that builds gtk3 & consumers. Otherwise, I don't see a better option than manual testing with big scary warnings.

@dg0yt
Copy link
Contributor

dg0yt commented Jul 15, 2021

@ras0219-msft gtk3 is needed for wxwidgets on linux. Does gtk3 really conflict with gtk4 (like the ssl packages do)?

@Neumann-A
Copy link
Contributor

Does gtk3 really conflict with gtk4 (like the ssl packages do)?

according to the file list on linux/windows it looks like both versions could coexist in the same registry just like qt5 and qt6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider updating CI to Ubuntu 20.04
6 participants