New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Ubuntu 20.04. #18892
Update to Ubuntu 20.04. #18892
Conversation
Could you add |
…vm-dev dependency
ff006c2
to
2de3f6d
Compare
Done |
Also please add |
If this one builds without errors I'll merge it, if not I'll immediately start another one adding that. |
I mean: If this one builds OK, I'll merge this one, and start a new one right after adding that for you. If this one doesn't build OK, I'll add it here. |
I'm not sure I should do that; it seems to be dragging in a bunch of libraries that are also in vcpkg and thus are likely to create ABI conflicts? |
@ras0219-msft wrote that "100% we should not be using gtk3 from the system."
I proposed to add gtk-3, based on the last gtk port version that was based on gtk-3. |
If a package depends on gtk 3, it is incompatible with the current vcpkg CI, same as if a package wants boringssl or libressl. If we see enough need for gtk3, we can investigate other options like a separate CI pass that builds gtk3 & consumers. Otherwise, I don't see a better option than manual testing with big scary warnings. |
@ras0219-msft gtk3 is needed for wxwidgets on linux. Does gtk3 really conflict with gtk4 (like the ssl packages do)? |
according to the file list on linux/windows it looks like both versions could coexist in the same registry just like qt5 and qt6. |
Resolves #13624