[flatbuffers] upgrade the flatbuffers to v2.0.0

[jixingcn]

Describe the pull request

• What does your PR fix?

  Upgrade the flatbuffers to v2.0.0

• Which triplets are supported/not supported? Have you updated the [CI baseline]

  Yes

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

[JonLiu1993]

@jixingcn ,Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static？

[jixingcn]

@jixingcn ,Thanks for your pr.
have you tested the feature locally on x64-linux, x64-windows, and x64-windows-static？

My application use flatbuffers by x64-windows and x64-windiws-static. I think all features are tested or verified.

[mathisloge]

@JonLiu1993 @jixingcn it does seem a bit suspicious to add a 19000 lines patch file.
What is the context of this patch. Shouldn't it be a upstream change?

[JonLiu1993]

@JonLiu1993 @jixingcn it does seem a bit suspicious to add a 19000 lines patch file.
What is the context of this patch. Shouldn't it be a upstream change?

Sorry, I did not find a patch file with 19000 lines. Can you point it out for me? Thank you

[JonLiu1993]

@jixingcn,Please run the command "./vcpkg x-add-version flatbuffers --overwrite-version" and commit the changes again.

[jixingcn]

@JonLiu1993 @jixingcn it does seem a bit suspicious to add a 19000 lines patch file.
What is the context of this patch. Shouldn't it be a upstream change?

Sorry, I did not find a patch file with 19000 lines. Can you point it out for me? Thank you

You can find in 96e57b8.

Commit this patch because the pipeline's report. The 19000+ lines were generated by MNN's schema generate script and the latest flatc that was compiled by vcpkg.

[ras0219-msft]

We cannot commit a 19k line patch like this, especially since it will need to change every time flatbuffers updates -- instead, mnn's port should run flatc at build time to generate any needed files.

You can easily get a runnable flatc.exe by depending on flatbuffers as a host dependency:

{
  "dependencies": [
    { "host": true, "name": "flatbuffers" }
  ]
}

Then, in the portfile, you can use ${CURRENT_HOST_INSTALLED_DIR}/tools/... to access the host dependency.

[jixingcn]

We cannot commit a 19k line patch like this, especially since it will need to change every time flatbuffers updates -- instead, mnn's port should run flatc at build time to generate any needed files.

You can easily get a runnable flatc.exe by depending on flatbuffers as a host dependency:

{
  "dependencies": [
    { "host": true, "name": "flatbuffers" }
  ]
}

Then, in the portfile, you can use ${CURRENT_HOST_INSTALLED_DIR}/tools/... to access the host dependency.

OK, thanks. I will fix that.

[JonLiu1993]

@jixingcn ,Could you please take a look?
https://dev.azure.com/vcpkg/public/_build/results?buildId=56048&view=artifacts&pathAsName=false&type=publishedArtifacts

[jixingcn]

@jixingcn ,Could you please take a look?
https://dev.azure.com/vcpkg/public/_build/results?buildId=56048&view=artifacts&pathAsName=false&type=publishedArtifacts

Ok

[JonLiu1993]

@jixingcn ,Thanks for your contribution.

[jixingcn]

@jixingcn ,Thanks for your contribution.

Thanks for your patient. 😃