New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nativefiledialog port using build time include dir #18923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfhs
force-pushed
the
jfhs/fix-nativefiledialog
branch
from
July 12, 2021 22:35
45a1f5f
to
4394d9b
Compare
jfhs
force-pushed
the
jfhs/fix-nativefiledialog
branch
from
July 12, 2021 22:47
4394d9b
to
29f9654
Compare
JackBoosY
suggested changes
Jul 13, 2021
JackBoosY
added
category:port-bug
The issue is with a library, which is something the port should already support
requires:author-response
labels
Jul 13, 2021
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
JackBoosY
suggested changes
Jul 14, 2021
JackBoosY
approved these changes
Jul 14, 2021
JackBoosY
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
info:reviewed
Pull Request changes follow basic guidelines
labels
Jul 14, 2021
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes installed lib include path pointing to build-time location. Problem is in this bit:
For install target, BUILD_INTERFACE evaluates to empty string, which is expanded to current build folder and so
unofficial-nativefiledialog-config.cmake
has lines like these that include absolute build folder path:Separating into two different target_include_directories fixes it.
Which triplets are supported/not supported? Have you updated the CI baseline?
All (except UWP), No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes