Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vcpkg-tool to 2021-07-16. #18983

Merged
merged 1 commit into from Jul 17, 2021
Merged

Update vcpkg-tool to 2021-07-16. #18983

merged 1 commit into from Jul 17, 2021

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Jul 17, 2021
@BillyONeal BillyONeal mentioned this pull request Jul 17, 2021
Merged
@BillyONeal BillyONeal added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jul 17, 2021
@BillyONeal BillyONeal force-pushed the update-version branch 2 times, most recently from 1a947d3 to cce74ae Compare July 17, 2021 05:17
@BillyONeal BillyONeal merged commit 111220b into microsoft:master Jul 17, 2021
@BillyONeal BillyONeal deleted the update-version branch July 17, 2021 16:51
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jul 18, 2021
@Jimmy-Hu
Merge pull request #676 from microsoft/master
3b9b4ac 
Update vcpkg-tool to 2021-07-16. (microsoft#18983)
@dg0yt
Copy link
Contributor

dg0yt commented Jul 18, 2021

You updated bootstrapping. Will you update the requirements in ports.cmake to make people upgrade vcpkg-tool before updating cmake?

vcpkg/scripts/ports.cmake

Lines 28 to 29 in 111220b

include("${SCRIPTS}/cmake/vcpkg_minimum_required.cmake")
vcpkg_minimum_required(VERSION 2021-05-05)

@BillyONeal
Copy link
Member Author

You updated bootstrapping. Will you update the requirements in ports.cmake to make people upgrade vcpkg-tool before updating cmake?

vcpkg/scripts/ports.cmake

Lines 28 to 29 in 111220b

include("${SCRIPTS}/cmake/vcpkg_minimum_required.cmake")
vcpkg_minimum_required(VERSION 2021-05-05)

We intentionally don’t update that unless we have a specific reason to force a rebootstrap; the cmake version update seems a good reason to me so maybe it should go in that review? I can prepare a stand-alone update PR if you wish

@dg0yt
Copy link
Contributor

dg0yt commented Jul 19, 2021

I made a comment in #18955 now.

We intentionally don’t update that unless we have a specific reason to force a rebootstrap

It might be forced for CMAKE_VERSION VERSION_GREATER 3.21 to limit scope, but OTOH this might not be desired from a maintenance point of view.

@strega-nil-ms strega-nil-ms mentioned this pull request Jul 19, 2021
Closed
@BillyONeal
Copy link
Member Author

It might be forced for CMAKE_VERSION VERSION_GREATER 3.21 to limit scope, but OTOH this might not be desired from a maintenance point of view.

That's already always true because the vcpkg binary will already download 3.21 if the one on the system is older than the one it has configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees
No one assigned
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BillyONeal @dg0yt @ras0219-msft @strega-nil-ms