Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imguizmo] new port #18991

Merged
merged 10 commits into from Jul 22, 2021
Merged

[imguizmo] new port #18991

merged 10 commits into from Jul 22, 2021

Conversation

JonathanHiggs
Copy link
Contributor

Adding a port for the ImGuizmo library to go along with ImGui and ImPlot

Source library uses a make build so this port uses the same method of ImPlot to define a CMakeLists.txt in the port and copy it over during install to correctly build the project

Source library is not versioned, I have an open issue about whether there they will use releases. Currently I am using a yyyy-mm-dd as the version string

  • What does your PR fix?

    Adds a port for ImGuizmo

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

    Tested x86-windows, x64-windows, x64-linux sucessfully, unable to test others

  • Does your PR follow the maintainer guide?

    As far as I know. Port is very similar to pre-existing ImPlot port, and the example code in source repo is excluded by the custom CMakeLists.txt included in the port directory

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Jul 17, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Jul 19, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 19, 2021
ports/imguizmo/vcpkg.json Outdated Show resolved Hide resolved
ports/imguizmo/portfile.cmake Outdated Show resolved Hide resolved
ports/imguizmo/portfile.cmake Outdated Show resolved Hide resolved
ports/imguizmo/portfile.cmake Outdated Show resolved Hide resolved
ports/imguizmo/portfile.cmake Outdated Show resolved Hide resolved
ports/imguizmo/vcpkg.json Outdated Show resolved Hide resolved
ports/imguizmo/portfile.cmake Outdated Show resolved Hide resolved
JonathanHiggs and others added 2 commits July 19, 2021 18:28
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
@JonLiu1993
Copy link
Member

@JonathanHiggs
Copy link
Contributor Author

Does osx run without std11 even?

@PhoebeHui
Copy link
Contributor

@JonathanHiggs, you need 'add_compile_options(-std=c++11)' in your CMakeLists.txt for osx if it needed.

Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
@JonathanHiggs
Copy link
Contributor Author

Is it add_compile_options() or target_compile_options() I need to set the cxx std? Will the both work cross-platform?

@PhoebeHui
Copy link
Contributor

@JonathanHiggs, please use target_compile_options().

JonathanHiggs and others added 2 commits July 20, 2021 10:21
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 20, 2021
@vicroms vicroms merged commit 3547cd9 into microsoft:master Jul 22, 2021
@vicroms
Copy link
Member

vicroms commented Jul 22, 2021

Thanks for the PR!

@JonathanHiggs JonathanHiggs deleted the feature-imguizmo branch July 22, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants