Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libffi] Update to v3.4.2 #18995

Merged
merged 4 commits into from
Jul 19, 2021
Merged

[libffi] Update to v3.4.2 #18995

merged 4 commits into from
Jul 19, 2021

Conversation

longnguyen2004
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes libffi build failure #18076
    Update libffi to v3.4.2 and remove upstreamed patches

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, not needed

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@longnguyen2004 longnguyen2004 mentioned this pull request Jul 18, 2021
Closed
@talregev
Copy link
Contributor

I am run it on the ci. I will let you know the result.

@talregev
Copy link
Contributor

I also check on my wsl:
I can confirm it working for:
--triplet=x64-mingw-static
it not working for:
--triplet=x86-mingw-static

Not sure if we need to support x86?

@talregev
Copy link
Contributor

For x86-mingw-static

CMake Error at CMakeLists.txt:19 (message):
  Unknown processor: i686

logs:
libffi.zip

@talregev
Copy link
Contributor

Now I can confirm it working on my wsl also with --triplet=x86-mingw-static

Thank you.

@JonLiu1993 JonLiu1993 self-assigned this Jul 19, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 19, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 19, 2021
@BillyONeal BillyONeal merged commit 3a28333 into microsoft:master Jul 19, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

@talregev
Copy link
Contributor

Thank you!

@longnguyen2004 longnguyen2004 deleted the libffi-v3.4.2 branch July 20, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libffi build failure
4 participants
@longnguyen2004 @talregev @BillyONeal @JonLiu1993