New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] Update to stable version 9.1.269.39 #18998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:port-update
The issue is with a library, which is requesting update new revision
label
Jul 19, 2021
Kwizatz
force-pushed
the
v8
branch
4 times, most recently
from
July 19, 2021 22:20
673cbb8
to
bb3c2aa
Compare
JackBoosY
reviewed
Jul 20, 2021
JackBoosY
suggested changes
Jul 20, 2021
Kwizatz
force-pushed
the
v8
branch
2 times, most recently
from
July 20, 2021 01:41
59a2be5
to
9718dd5
Compare
|
I think I'll just desist on fixing #17536 for now, to be honest the previous fix was optimal for me, at least for clang builds on Linux, Windows definitely does require more work as I recently experienced doing the mingw clang version. I'll upload a simple version update patch soon. |
Ready for review now? |
Sure |
JackBoosY
approved these changes
Jul 27, 2021
JackBoosY
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for clang builds when environment variables are set accordingly:
CC=clang
CXX=clang
AR=llvm-ar
NM=llvm-nm
Describe the pull request
Update to stable version 9.1.269.39
What does your PR fix?
Fixes [v8] build failure #17536
Which triplets are supported/not supported? Have you updated the CI baseline?
windows, windows-static, linux. Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
Yes./vcpkg x-add-version --all
and committed the result?If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/