Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure SDK] Update Azure SDK to the latest version #19028

Merged
merged 1 commit into from Jul 22, 2021
Merged

[Azure SDK] Update Azure SDK to the latest version #19028

merged 1 commit into from Jul 22, 2021

Conversation

azure-sdk
Copy link
Contributor

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

@azure-sdk
[azure-security-keyvault-keys-cpp] Update to 4.0.0-beta.4
22d9b4c 
## 4.0.0-beta.4 (2021-07-20)

### Features Added

- Added `GetIv()` to `EncryptParameters` and `DecryptParameters`.
- Added `BackupKeyResult` for `BackupKey()` return type.

### Breaking Changes

- Removed `Azure::Security::KeyVault::Keys::ServiceVersion::V7_0` and `V7_1`.
- Removed `Azure::Security::KeyVault::Keys::Cryptography::ServiceVersion::V7_0` and `V7_1`.
- Removed `CryptographyClient::RemoteClient()` and `CryptographyClient::LocalOnly()`.
- Removed the general constructor from `EncryptParameters` and `DecryptParameters`.
- Removed access to `Iv` field member from `EncryptParameters` and `DecryptParameters`.
- Removed `Encrypt(EncryptionAlgorithm, std::vector, context)`.
- Removed `Decrypt(DecryptAlgorithm, std::vector, context)`.
- Removed `JsonWebKey::HasPrivateKey()`.
- Removed the `MaxPageResults` field from `GetPropertiesOfKeysOptions`, `GetPropertiesOfKeyVersionsOptions`, and `GetDeletedKeysOptions`.
- Renamed header `list_keys_single_page_result.hpp` to `list_keys_responses.hpp`.
- Updated `BackupKey()` API return type to `BackupKeyResult` model type.
- Renamed `KeyPropertiesPageResult` to `KeyPropertiesPagedResponse`.
- Renamed `DeletedKeyPageResult` to `DeletedKeyPagedResponse`.
- Changed the container for `KeyOperations` from `std::list` to `std::vector` within `CreateKeyOptions` and `UpdateKeyProperties()`.
- Changed the return type of `CrytographyClient` APIs like `Encrypt()` to return `Response<T>` rather than the `T` directly.
- Renamed high-level header from `key_vault_keys.hpp` to `keyvault_keys.hpp`.
@JonLiu1993 JonLiu1993 self-assigned this Jul 21, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 21, 2021
@JonLiu1993 JonLiu1993 changed the title Azure SDK Key Vault Jul Release [Azure SDK] Update Azure SDK to the latest version Jul 21, 2021
JonLiu1993
JonLiu1993 requested changes Jul 21, 2021
View reviewed changes
Copy link
Member

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azure-sdk ,Please delete PREFER_NINJA in the vcpkg_cmake_configure

@ahsonkhan
Copy link
Member

Please delete PREFER_NINJA in the vcpkg_cmake_configure

Can you please explain why? This PR isn't touching that aspect nor adding it, so we'd prefer to that separately for the next release and unblock the current PR, unless there is a functional correctness reason that it must be fixed now.

Thanks!
@ras0219-msft, @antkmsft, @vhvb1989, @RickWinter

@danieljurek - can we please update the PR generation to auto-tag/cc the Azure SDK C++ dev team, so we can get notified and follow-up on such feedback and releases?

@JonLiu1993
Copy link
Member

@azure-sdk ,Please delete PREFER_NINJA in the vcpkg_cmake_configure

@ahsonkhan ,According to the description of the vcpkg_cmake_configure function, Ninja compilation is used by default, so we generally delete PREFER_NINJA

By default, when possible, `vcpkg_cmake_configure` uses [ninja-build]
as its build system. If the `WINDOWS_USE_MSBUILD` argument is passed, then
`vcpkg_cmake_configure` will use a Visual Studio generator on Windows;
on every other platform, `vcpkg_cmake_configure` just uses Ninja.

@ahsonkhan
Copy link
Member

ahsonkhan commented Jul 22, 2021 •
edited

Since that is just redundant (and not incorrect), can we merge this as is for now, and make the change in our repo for the next release?

We'd want to make the change here first, later:
https://github.com/Azure/azure-sdk-for-cpp/blob/e4d5e31371ce8e47a9c5d60c02e240dc00575f31/sdk/keyvault/azure-security-keyvault-keys/vcpkg/portfile.cmake#L11-L16

@ras0219-msft ras0219-msft merged commit c2e8ba0 into microsoft:master Jul 22, 2021
@ras0219-msft
Copy link
Contributor

This looks like a straightforward update and so doesn't need to block on fixing the PREFER_NINJA for now.

@ahsonkhan ahsonkhan deleted the azure-sdk-for-cpp-keyvault-jul-2021 branch July 22, 2021 18:15
This was referenced Jul 22, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 requested changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@azure-sdk @ahsonkhan @JonLiu1993 @ras0219-msft