Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rxspencer] Update to latest release 3.9.0 and also support dynamic build #19039

Merged
merged 3 commits into from Jul 22, 2021
Merged

[rxspencer] Update to latest release 3.9.0 and also support dynamic build #19039

merged 3 commits into from Jul 22, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

rxspencer failed on x86-windows with the following errors:

D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(127): error C2059: syntax error: '>'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(127): error C2059: syntax error: ')'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(129): error C2059: syntax error: 'if'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2059: syntax error: 'string'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2143: syntax error: missing ')' before '->'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2143: syntax error: missing '{' before '->'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2059: syntax error: '->'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(132): error C2059: syntax error: ')'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(133): error C2059: syntax error: 'return'
D:\buildtrees\rxspencer\src\58e5a26934-bbc7804fdb.clean\regerror.c(134): error C2059: syntax error: '}'

regerror.c has been refactored. So update to the latest version 3.9.0. Also support dynamic build.

Related #18944.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jul 21, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Jul 21, 2021
Merged
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 22, 2021
@vicroms vicroms merged commit b04a32a into microsoft:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NancyLi1013 @JackBoosY @vicroms