Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit stderr on successful bootstrap. #19175

Merged
merged 2 commits into from Jul 27, 2021

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Jul 27, 2021
scripts/bootstrap.sh Outdated Show resolved Hide resolved
@brycelelbach
Copy link

Context: it can be annoying to have tools output to stderr in non-error cases, because some consoles/UIs highlight errors in a special way. You don't want attention called too non-error cases. The unfortunate alternative is to redirect stderr to stdout, but then real errors don't get highlighted.

This came up when I was adding vcpkg into the Docker images we use for github.com/NVIDIA/thrust and github.com/NVIDIA/cub

bootstrap_vcpkg_sh_curl_stderr

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@BillyONeal BillyONeal merged commit 9f8a74d into microsoft:master Jul 27, 2021
@BillyONeal BillyONeal deleted the quiet-curl branch July 27, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants