[tensorflow-cc] on x64 Windows with dynamic linkage misses C++ symbols in DLL #19364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incorporate changes from microsoft:master
Revert "incorporate changes from microsoft:master"
because the DLL only exports the C API, not the C++ API; remove this error again once this is fixed upstream
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8cadbc5..460ae8d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6206,7 +6206,7 @@
},
"tensorflow-cc": {
"baseline": "2.4.1",
- "port-version": 0
+ "port-version": 1
},
"tensorflow-common": {
"baseline": "2.4.1",
diff --git a/versions/t-/tensorflow-cc.json b/versions/t-/tensorflow-cc.json
index 1711cad..83dc7f2 100644
--- a/versions/t-/tensorflow-cc.json
+++ b/versions/t-/tensorflow-cc.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "984add9e42f747af35ee3cece3460482ed4dc77b",
+ "version-semver": "2.4.1",
+ "port-version": 1
+ },
{
"git-tree": "868e7ae57409669692df84ddb446f4a235e0b220",
"version-semver": "2.4.1",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8cadbc5..460ae8d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6206,7 +6206,7 @@
},
"tensorflow-cc": {
"baseline": "2.4.1",
- "port-version": 0
+ "port-version": 1
},
"tensorflow-common": {
"baseline": "2.4.1",
diff --git a/versions/t-/tensorflow-cc.json b/versions/t-/tensorflow-cc.json
index 1711cad..83dc7f2 100644
--- a/versions/t-/tensorflow-cc.json
+++ b/versions/t-/tensorflow-cc.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "984add9e42f747af35ee3cece3460482ed4dc77b",
+ "version-semver": "2.4.1",
+ "port-version": 1
+ },
{
"git-tree": "868e7ae57409669692df84ddb446f4a235e0b220",
"version-semver": "2.4.1",
Hoikas
reviewed
Aug 4, 2021
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd5ea16b97e91cb620fed0e10b7d9b3a8a943a52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/t-/tensorflow-cc.json b/versions/t-/tensorflow-cc.json
index 83dc7f2..b43b8b2 100644
--- a/versions/t-/tensorflow-cc.json
+++ b/versions/t-/tensorflow-cc.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "984add9e42f747af35ee3cece3460482ed4dc77b",
+ "git-tree": "77875da04a151fb36abe52cce80491a9a7f16c55",
"version-semver": "2.4.1",
"port-version": 1
},
With the changes, the library now always builds static on Windows, so the PR description should probably be updated 😉 |
JackBoosY
approved these changes
Aug 5, 2021
JackBoosY
added
category:port-bug
|
LGTM on my side. |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DLL appears to only export C API, but not C++ API. Always build static C++ library until this is fixed upstream.
Fixes #18887.