Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure SDK Key Vault Keys] update version to 4.0.0 GA #19487

Merged

Conversation

azure-sdk
Copy link
Contributor

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

## 4.0.0 (2021-08-10)

### Other Changes

- Consolidated keyvault and cryptography client options and model files into single headers.
@JonLiu1993 JonLiu1993 self-assigned this Aug 11, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 11, 2021
"description": [
"Microsoft Azure Key Vault Keys SDK for C++",
"This library provides Azure Key Vault Keys SDK."
],
"homepage": "https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-keys",
"license": "MIT",
"builtin-baseline": "14c54c49b56a964ac7f2f701a6857adb02ae1bec",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"builtin-baseline": "14c54c49b56a964ac7f2f701a6857adb02ae1bec",

"dependencies": [
{
"name": "azure-core-cpp",
"default-features": false
"default-features": false,
"version>=": "1.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version>=": "1.1.0"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69478c5caafcde4c490bb1fccb960296801dbb5f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/azure-security-keyvault-keys-cpp.json b/versions/a-/azure-security-keyvault-keys-cpp.json
index 50af262..2505c7e 100644
--- a/versions/a-/azure-security-keyvault-keys-cpp.json
+++ b/versions/a-/azure-security-keyvault-keys-cpp.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "a8a528b35c8ee051b4b66c90eca0078c6fe8d432",
+      "git-tree": "b710e9d89ef00e649c793f46ce7c67af63fa3611",
       "version-semver": "4.0.0",
       "port-version": 0
     },

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69478c5caafcde4c490bb1fccb960296801dbb5f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/azure-security-keyvault-keys-cpp.json b/versions/a-/azure-security-keyvault-keys-cpp.json
index 68ac668..2505c7e 100644
--- a/versions/a-/azure-security-keyvault-keys-cpp.json
+++ b/versions/a-/azure-security-keyvault-keys-cpp.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b710e9d89ef00e649c793f46ce7c67af63fa3611",
+      "version-semver": "4.0.0",
+      "port-version": 0
+    },
     {
       "git-tree": "6a62e90cc13ab362ba09462fa444512aee671482",
       "version-semver": "4.0.0-beta.4",
diff --git a/versions/baseline.json b/versions/baseline.json
index ecae6d2..a2d1692 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -297,8 +297,8 @@
       "port-version": 0
     },
     "azure-security-keyvault-keys-cpp": {
-      "baseline": "4.0.0-beta.4",
-      "port-version": 1
+      "baseline": "4.0.0",
+      "port-version": 0
     },
     "azure-storage-blobs-cpp": {
       "baseline": "12.0.1",

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonLiu1993, I removed the version constraints.

This reverts commit c6ad64b.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69478c5caafcde4c490bb1fccb960296801dbb5f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/azure-security-keyvault-keys-cpp.json b/versions/a-/azure-security-keyvault-keys-cpp.json
index 50af262..2505c7e 100644
--- a/versions/a-/azure-security-keyvault-keys-cpp.json
+++ b/versions/a-/azure-security-keyvault-keys-cpp.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "a8a528b35c8ee051b4b66c90eca0078c6fe8d432",
+      "git-tree": "b710e9d89ef00e649c793f46ce7c67af63fa3611",
       "version-semver": "4.0.0",
       "port-version": 0
     },

@antkmsft
Copy link
Member

@JonLiu1993, the button to re-request the review is not available to me, so I am asking to by writing this message :)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 11, 2021
@BillyONeal BillyONeal merged commit 29c6630 into microsoft:master Aug 12, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

@ahsonkhan ahsonkhan deleted the azure-sdk-for-cpp-keyvault-keys-4 branch January 12, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants