Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[allergo5] Export cmake targets, disable install pdbs to lib #19493

Merged

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 11, 2021

This PR will:

  • Export all allegro5 cmake targets:
The package allegro5:x86-windows provides CMake targets:

    find_package(unofficial-allegro5 CONFIG REQUIRED)
    # Note: 9 target(s) were omitted.
    target_link_libraries(main PRIVATE unofficial-allegro5::allegro unofficial-allegro5::allegro_ttf unofficial-allegro5::allegro_font unofficial-allegro5::allegro_main)

Closes #17108 #17055

Already tested the usage.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Aug 11, 2021
@JackBoosY JackBoosY linked an issue Aug 11, 2021 that may be closed by this pull request
@JackBoosY JackBoosY linked an issue Aug 11, 2021 that may be closed by this pull request
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 11, 2021
@ras0219-msft ras0219-msft removed the info:reviewed Pull Request changes follow basic guidelines label Sep 1, 2021
@PhoebeHui PhoebeHui marked this pull request as draft September 17, 2021 06:45
@JackBoosY JackBoosY marked this pull request as ready for review October 12, 2021 07:35
@JackBoosY JackBoosY added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 13, 2021
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM after my two suggestions are applied.

ports/allegro5/export-targets.patch Outdated Show resolved Hide resolved
ports/allegro5/export-targets.patch Outdated Show resolved Hide resolved
@JackBoosY JackBoosY removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Nov 16, 2021
@ras0219-msft ras0219-msft merged commit d8b9ae5 into microsoft:master Nov 23, 2021
@ras0219-msft
Copy link
Contributor

Thanks!

@JackBoosY JackBoosY deleted the dev/jack/allegro5-export-targets branch November 24, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[allegro5] How do I use it? [nuklear] fatal error: 'malloc.h' file not found
7 participants