[Sockpp][Android] Compile Sockpp port for android

[talregev]

Compile Sockpp port for android

[talregev]

I want to compile sockpp in mingw-static
i get this error:
error: 'inet_ntop' was not declared in this scope;

I search in stack overflow:
I want to try this solution:
#define _WIN32_WINNT 0x0601
https://stackoverflow.com/a/64577702/550384

For my trial:
https://github.com/microsoft/vcpkg/pull/19769/files#diff-6dd900697e25811d0b4e4d5e91f7d2efed33b150b354338469fb62a978b3beb1R27
I get this error:

The following variables are not used in CMakeLists.txt:

      _WIN32_WINNT

Can someone help?

I guess I define the _WIN32_WINNT inside cmake and not inside the code as I intended.

[talregev]

It already do it?
https://github.com/microsoft/vcpkg-tool/blob/main/CMakeLists.txt#L165

[talregev]

I decided to focus here only for android. then do another PR for mingw.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/sockpp.json b/versions/s-/sockpp.json
index c8ad519..dbedea1 100644
--- a/versions/s-/sockpp.json
+++ b/versions/s-/sockpp.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "18610a158f9f9185e68c84365f38a250ab333b4a",
+      "git-tree": "97a77b226a4c2a655daac0100ec95411b9abbace",
       "version": "0.7",
       "port-version": 1
     },

[BillyONeal]

I see, it was submitted upstream. The upstream maintainer seems responsive, so I think we should see prognosis of fpagliughi/sockpp#55

[JackBoosY]

Change this PR to draft until the upstream approve the changes.

[talregev]

@JackBoosY @BillyONeal The upstream was merged. Can you review it again?

[talregev]

@JackBoosY Can you help me with the conflicts?

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout b18b17865cfb6bd24620a00f30691be6775abb96 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/sockpp.json b/versions/s-/sockpp.json
index 80d29c33..a3fa2069 100644
--- a/versions/s-/sockpp.json
+++ b/versions/s-/sockpp.json
@@ -6,8 +6,8 @@
       "port-version": 2
     },
     {
-      "git-tree": "97a77b226a4c2a655daac0100ec95411b9abbace",
-      "version": "0.7",
+      "git-tree": "69d23d693d1ab8cfeeab35c6b2794d6f2a9ca748",
+      "version-string": "0.7",
       "port-version": 1
     },
     {

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

• ports/sockpp/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

• ports/sockpp/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

[ras0219-msft]

It looks like this patch was included in the minor release 0.7.1 from upstream (https://github.com/fpagliughi/sockpp). Could we change this PR to a simple update that doesn't need the patch?

With that change, LGTM!

[talregev]

It looks like this patch was included in the minor release 0.7.1 from upstream (https://github.com/fpagliughi/sockpp). Could we change this PR to a simple update that doesn't need the patch?

With that change, LGTM!

I agree!
@JackBoosY Can you help?

[JackBoosY]

I should keep this PR folder on my disk 😢

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

• ports/sockpp/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

• ports/sockpp/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

[BillyONeal]

Thanks <3