[ned14-internal-quickcpplib/llfio/outcome] Update to latest release #20171

ned14 · 2021-09-15T10:41:45Z

Describe the pull request

What does your PR fix?

Update ned14-internal-quickcpplib and LLFIO to latest matching Outcome v2.2.1 (bugfixed) release.

Which triplets are supported/not supported? Have you updated the [CI baseline]

All the same as before.

Does your PR follow the maintainer guide?

Yes.

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

…e v2.2.1 (bugfixed) release.

ned14 · 2021-09-15T11:00:33Z

Looks like "Test Modified Ports and Prepare Test Logs" is failing for the Windows targets. Obviously this is new since I last submitted a version bump.

Do I need to add something about test status to some file in the commit or something?

BillyONeal · 2021-09-15T21:22:52Z

Looks like "Test Modified Ports and Prepare Test Logs" is failing for the Windows targets. Obviously this is new since I last submitted a version bump.

We added an overzealous check, I removed the check and pushed a merge with master for you.

BillyONeal · 2021-09-15T21:23:13Z

/azp run

azure-pipelines · 2021-09-15T21:23:22Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoebeHui

@ned14, thanks for the PR! Could you address the review suggestions?

ports/ned14-internal-quickcpplib/vcpkg.json

ports/outcome/vcpkg.json

ports/llfio/vcpkg.json

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/llfio/portfile.cmake
ports/ned14-internal-quickcpplib/portfile.cmake
ports/outcome/portfile.cmake

ned14 · 2021-09-22T08:38:46Z

Can you not merge this as is please? One of the reasons I'm late getting back to this PR is because a showstopper memory corruption bug was present in this edition of LLFIO. Everything needs bumped to latest versions. I'll try to find time to do it soon.

…o latest.

ned14 · 2021-09-22T11:16:02Z

Ok moved to latest everything, fixed suggested items from review.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 47d2378c8181ece05ffc51acd2ed60d97e3c9a64 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 738e6b8..316d959 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4490,7 +4490,7 @@
     },
     "ned14-internal-quickcpplib": {
       "baseline": "0.0.0-e691a6dc",
-      "port-version": 1
+      "port-version": 0
     },
     "neon2sse": {
       "baseline": "2021-09-16",
diff --git a/versions/l-/llfio.json b/versions/l-/llfio.json
index b21094a..fa6953f 100644
--- a/versions/l-/llfio.json
+++ b/versions/l-/llfio.json
@@ -14,6 +14,11 @@
       "git-tree": "ffb9aa3f751b213fd6bde4d06f1c694c489e08f0",
       "version-string": "2.0-20210420",
       "port-version": 0
+    },
+    {
+      "git-tree": "debab55b24a36f3615bd29f0fe3088032bd61e53",
+      "version-string": "2.0-a74411ed",
+      "port-version": 0
     }
   ]
 }
diff --git a/versions/n-/ned14-internal-quickcpplib.json b/versions/n-/ned14-internal-quickcpplib.json
index 08f8e23..2c4ad5c 100644
--- a/versions/n-/ned14-internal-quickcpplib.json
+++ b/versions/n-/ned14-internal-quickcpplib.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "4ab01a05efd3fbf320d64a4914983606adb55fb5",
+      "git-tree": "801be68901e5e7e84e4069015346fc457e72953c",
       "version-string": "0.0.0-e691a6dc",
-      "port-version": 1
+      "port-version": 0
     },
     {
       "git-tree": "3cd8528057f78bdbc43616bbe7349acd5cc41c77",
diff --git a/versions/o-/outcome.json b/versions/o-/outcome.json
index c3b5a02..6c50899 100644
--- a/versions/o-/outcome.json
+++ b/versions/o-/outcome.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "250b9fe23bacf477fcd64d8834db701986ae1a6c",
+      "git-tree": "31aada521fafc8169a891338a3af04fa4f658327",
       "version-string": "2.2.2-20210922",
       "port-version": 0
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/llfio/portfile.cmake
ports/ned14-internal-quickcpplib/portfile.cmake
ports/outcome/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9d892ff9270f2d2fe3b8e490471f0a7dfa78981e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/llfio.json b/versions/l-/llfio.json
index b21094a..fa6953f 100644
--- a/versions/l-/llfio.json
+++ b/versions/l-/llfio.json
@@ -14,6 +14,11 @@
       "git-tree": "ffb9aa3f751b213fd6bde4d06f1c694c489e08f0",
       "version-string": "2.0-20210420",
       "port-version": 0
+    },
+    {
+      "git-tree": "debab55b24a36f3615bd29f0fe3088032bd61e53",
+      "version-string": "2.0-a74411ed",
+      "port-version": 0
     }
   ]
 }
diff --git a/versions/n-/ned14-internal-quickcpplib.json b/versions/n-/ned14-internal-quickcpplib.json
index b706b9e..2c4ad5c 100644
--- a/versions/n-/ned14-internal-quickcpplib.json
+++ b/versions/n-/ned14-internal-quickcpplib.json
@@ -5,11 +5,6 @@
       "version-string": "0.0.0-e691a6dc",
       "port-version": 0
     },
-    {
-      "git-tree": "4ab01a05efd3fbf320d64a4914983606adb55fb5",
-      "version-string": "0.0.0-e691a6dc",
-      "port-version": 1
-    },
     {
       "git-tree": "3cd8528057f78bdbc43616bbe7349acd5cc41c77",
       "version-string": "0.0.0-7cb75d4e",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/llfio/portfile.cmake
ports/ned14-internal-quickcpplib/portfile.cmake
ports/outcome/portfile.cmake

BillyONeal · 2021-09-24T00:42:05Z

Can you not merge this as is please? One of the reasons I'm late getting back to this PR is because a showstopper memory corruption bug was present in this edition of LLFIO. Everything needs bumped to latest versions. I'll try to find time to do it soon.

You can also just close the PR whenever that happens and reopen later :)

PhoebeHui

Thanks for the updates

ned14 · 2021-09-24T13:11:59Z

You can also just close the PR whenever that happens and reopen later :)

It's kinda hard to know what the expected process semantics are for PRs across different orgs. Some get real arsey if you close and open PRs. Or open PRs at all without a preceding issue. Even here in vcpkg I've noticed quite a lot of change in the past year in terms of vibe and process. Probably your influence Billy :)

Re: this one change requested above, I don't understand it. Didn't I already update the versions last commit I did? If I did it wrong, I'll need instruction on how to do it better, I merged latest master, readded versions, commit. I don't know what else I am supposed to do.

BillyONeal · 2021-09-24T17:53:35Z

It's kinda hard to know what the expected process semantics are for PRs across different orgs. Some get real arsey if you close and open PRs. Or open PRs at all without a preceding issue. Even here in vcpkg I've noticed quite a lot of change in the past year in terms of vibe and process. Probably your influence Billy :)

I hope you're getting a good experience contributing :)

Re: this one change requested above, I don't understand it. Didn't I already update the versions last commit I did? If I did it wrong, I'll need instruction on how to do it better, I merged latest master, readded versions, commit. I don't know what else I am supposed to do.

The version database should have only 1 new version entry added per port per PR; this change removes an entry:

and adds multiple entries:

A good way to fix this is to (1) merge with origin/master, (2) git checkout origin/master -- versions, then rerun any commands to touch the version database. I'm just going to fix this one for you though....

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/llfio/portfile.cmake
ports/ned14-internal-quickcpplib/portfile.cmake
ports/outcome/portfile.cmake

BillyONeal

Will land as soon as build comes back.

ned14 · 2021-09-27T13:41:43Z

The version database should have only 1 new version entry added per port per PR; this change removes an entry:

That was intentional.

and adds multiple entries:

That was not. I wanted only the one with port-version: 0, but obviously vcpkg readded in the other one.

BillyONeal · 2021-09-27T19:42:32Z

The version database should have only 1 new version entry added per port per PR; this change removes an entry:

That was intentional.

Version entries can never be removed.

and adds multiple entries:

That was not. I wanted only the one with port-version: 0, but obviously vcpkg readded in the other one.

Your vcpkg.json has port-version: 1 so it kept trying to add that one.

BillyONeal · 2021-09-27T19:42:48Z

Thanks for the version updates!

Update ned14-internal-quickcpplib and LLFIO to latest matching Outcom…

f17e7d9

…e v2.2.1 (bugfixed) release.

github-actions bot approved these changes Sep 15, 2021

View reviewed changes

PhoebeHui self-assigned this Sep 16, 2021

PhoebeHui changed the title ~~Update ned14-internal-quickcpplib and LLFIO to latest matching Outcome v2.2.1 (bugfixed) release.~~ [ned14-internal-quickcpplib/llfio/outcome] Update to latest release Sep 16, 2021

PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Sep 16, 2021

PhoebeHui requested changes Sep 16, 2021

View reviewed changes

ports/ned14-internal-quickcpplib/vcpkg.json Outdated Show resolved Hide resolved

ports/outcome/vcpkg.json Outdated Show resolved Hide resolved

ports/llfio/vcpkg.json Outdated Show resolved Hide resolved

ports/llfio/vcpkg.json Outdated Show resolved Hide resolved

PhoebeHui added requires:author-response and removed requires:author-response labels Sep 16, 2021

github-actions bot approved these changes Sep 22, 2021

View reviewed changes

PhoebeHui approved these changes Sep 22, 2021

View reviewed changes

PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 22, 2021

ned14 added 2 commits September 22, 2021 12:00

Merge branch 'master' of https://github.com/microsoft/vcpkg

1f694cd

Implement suggested changes during review. Update Outcome and LLFIO t…

eedc048

…o latest.

ned14 force-pushed the master branch from 6fbd541 to eedc048 Compare September 22, 2021 11:15

github-actions bot requested changes Sep 22, 2021

View reviewed changes

strega-nil-ms added the requires:author-response label Sep 22, 2021

ned14 added 2 commits September 23, 2021 16:58

Merge branch 'master' of https://github.com/microsoft/vcpkg

eccd96b

Re x-add-version.

39dd304

github-actions bot requested changes Sep 23, 2021

View reviewed changes

BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2021

PhoebeHui removed the requires:author-response label Sep 24, 2021

PhoebeHui approved these changes Sep 24, 2021

View reviewed changes

PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2021

BillyONeal added 2 commits September 24, 2021 10:54

Merge remote-tracking branch 'origin/master' into HEAD

3339d8b

Fix version database.

8964caa

github-actions bot approved these changes Sep 24, 2021

View reviewed changes

BillyONeal approved these changes Sep 24, 2021

View reviewed changes

BillyONeal merged commit 46700e2 into microsoft:master Sep 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ned14-internal-quickcpplib/llfio/outcome] Update to latest release #20171

[ned14-internal-quickcpplib/llfio/outcome] Update to latest release #20171

ned14 commented Sep 15, 2021

ned14 commented Sep 15, 2021

BillyONeal commented Sep 15, 2021

BillyONeal commented Sep 15, 2021

azure-pipelines bot commented Sep 15, 2021

PhoebeHui left a comment

github-actions bot left a comment

ned14 commented Sep 22, 2021

ned14 commented Sep 22, 2021

github-actions bot left a comment

github-actions bot left a comment

BillyONeal commented Sep 24, 2021

PhoebeHui left a comment

ned14 commented Sep 24, 2021

BillyONeal commented Sep 24, 2021

github-actions bot left a comment

BillyONeal left a comment

ned14 commented Sep 27, 2021

BillyONeal commented Sep 27, 2021

BillyONeal commented Sep 27, 2021

[ned14-internal-quickcpplib/llfio/outcome] Update to latest release #20171

[ned14-internal-quickcpplib/llfio/outcome] Update to latest release #20171

Conversation

ned14 commented Sep 15, 2021

What does your PR fix?

Which triplets are supported/not supported? Have you updated the [CI baseline]

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

ned14 commented Sep 15, 2021

BillyONeal commented Sep 15, 2021

BillyONeal commented Sep 15, 2021

azure-pipelines bot commented Sep 15, 2021

PhoebeHui left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

ned14 commented Sep 22, 2021

ned14 commented Sep 22, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

BillyONeal commented Sep 24, 2021

PhoebeHui left a comment

Choose a reason for hiding this comment

ned14 commented Sep 24, 2021

BillyONeal commented Sep 24, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

BillyONeal left a comment

Choose a reason for hiding this comment

ned14 commented Sep 27, 2021

BillyONeal commented Sep 27, 2021

BillyONeal commented Sep 27, 2021

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?