[expected-lite] Update port to 0.5.0 #20455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BillyONeal
reviewed
Oct 2, 2021
ports/expected-lite/vcpkg.json
Outdated
| "version-string": "0.3.0", | ||
| "port-version": 1, | ||
| "description": "Expected objects in C++11 and later in a single-file header-only library" | ||
| "version-semver": "0.5.0", |
There was a problem hiding this comment.
Can you point to where they say they actually do semver?
There was a problem hiding this comment.
(If they don't document that they follow semver rules then this should be just "version" rather than "version-semver"
There was a problem hiding this comment.
I based it off of the fact that the cmake version check uses the equivalent of SameMajorVersion compatibility, and the version macros in the header are listed as major.minor.patch, but I can't see it being documented as semver anywhere, so I'll use version instead.
|
Thanks @Ryan-rsm-McKenzie ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Updates expected-lite to 0.5.0
Which triplets are supported/not supported? Have you updated the CI baseline?
Just a port update
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes