-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libnice] Update to 0.1.18 #20556
[libnice] Update to 0.1.18 #20556
Conversation
Hmm CI logs tell me: |
@dg0yt: |
@Neumann-A I can't say for sure. Every project hacks it is own way around issues on some build environment, instead of just using pkg-config. I can check linux later, but my native mingw buildtree is discouraging:
(No results) |
On linux, I had one hit: nghttp2. (The Ubuntu module basically just |
(And nghttp2 has no openssl dependency in vcpkg.) |
@NancyLi1013: Since you put libnice on the ci skiplist, I'll let you figure out what is going on with gstreamer on osx. The linux build failure here is due to a missing openssl.pc from the openssl port within vcpkg. |
I skipped on the ci is just to solve the problem that the website cannot be accessed, please see #16473 (comment). It is just a temporary fix. The failures caused by
But I cannot get the details from For the problem on Linux:
|
@Neumann-A ,Is this PR being worked on? |
@JonLiu1993 Not by me. I can close it if you want. (see #20556 (comment)) |
…te_libnice # Conflicts: # scripts/ci.baseline.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libnice/vcpkg.json
Valid values for the license field can be found in the documentation
Thanks for the update! |
The openssl pkgconfig dependency should have been fixed by #20831 |
depends on [qt] Fix qtmultimedia with gstreamer on windows #20555 to solve the qtmultimedia regression