Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libnice] Update to 0.1.18 #20556

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Oct 6, 2021

@Neumann-A
Copy link
Contributor Author

Hmm CI logs tell me:
a) Linux pc file for openssl seems to be broken
b) Some linkage issue on osx which requires an extra log CI is not giving me.

@Neumann-A
Copy link
Contributor Author

@dg0yt:
You are currently fixing some pc files and dependencies. Have you seen the usage of openssl via *.pc files in there somewhere?

@dg0yt
Copy link
Contributor

dg0yt commented Oct 6, 2021

@Neumann-A I can't say for sure. Every project hacks it is own way around issues on some build environment, instead of just using pkg-config. I can check linux later, but my native mingw buildtree is discouraging:

 $ grep PKG_CHECK buildtrees/*/src/*/configure.ac  | grep "ssl\|crypto"

(No results)

@dg0yt
Copy link
Contributor

dg0yt commented Oct 6, 2021

On linux, I had one hit: nghttp2.
However, it looks for module "openssl". This module exists in my Ubuntu system, but vcpkg port openssl only creates libssl.pc and libcrypto.pc.

(The Ubuntu module basically just Requires: libssl libcrypt.)

@dg0yt
Copy link
Contributor

dg0yt commented Oct 6, 2021

On linux, I had one hit: nghttp2.

(And nghttp2 has no openssl dependency in vcpkg.)

@Neumann-A
Copy link
Contributor Author

@NancyLi1013: Since you put libnice on the ci skiplist, I'll let you figure out what is going on with gstreamer on osx. The linux build failure here is due to a missing openssl.pc from the openssl port within vcpkg.

@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 8, 2021
@NancyLi1013
Copy link
Contributor

@NancyLi1013: Since you put libnice on the ci skiplist, I'll let you figure out what is going on with gstreamer on osx. The linux build failure here is due to a missing openssl.pc from the openssl port within vcpkg.

I skipped on the ci is just to solve the problem that the website cannot be accessed, please see #16473 (comment). It is just a temporary fix.

The failures caused by gstreamer on osx are like this:

../src/1.19.2-dbedf5df9d.clean/meson.build:322:6: ERROR: Problem encountered: Failed to link with version script (/Users/vagrant/Data/buildtrees/gstreamer/src/1.19.2-dbedf5df9d.clean/gstreamer-full-default.map), check logs for details

A full log can be found at /Users/vagrant/Data/buildtrees/gstreamer/x64-osx-dbg/meson-logs/meson-log.txt

But I cannot get the details from /Users/vagrant/Data/buildtrees/gstreamer/x64-osx-dbg/meson-logs/meson-log.txt. I'm not sure what happened on this. I tried to reproduce this on my local machine, but was blocked by other problem.
@strega-nil, could you please help provide the details from /Users/vagrant/Data/buildtrees/gstreamer/x64-osx-dbg/meson-logs/meson-log.txt or how can we get this file?

For the problem on Linux:

Found pkg-config: /bin/pkg-config (0.29.1)
Run-time dependency gio-2.0 found: YES 2.66.4
Run-time dependency gthread-2.0 found: YES 2.66.4
Message: Crypto library requested: openssl
Found CMake: /mnt/vcpkg-ci/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake (3.21.1)
Run-time dependency openssl found: NO (tried pkgconfig and cmake)

../src/059acc748d-a1e57caf17.clean/meson.build:204:9: ERROR: Unknown variable "openssl".

A full log can be found at /mnt/vcpkg-ci/buildtrees/libnice/x64-linux-dbg/meson-logs/meson-log.txt

@JonLiu1993
Copy link
Member

@Neumann-A ,Is this PR being worked on?

@Neumann-A
Copy link
Contributor Author

@JonLiu1993 Not by me. I can close it if you want. (see #20556 (comment))

…te_libnice

# Conflicts:
#	scripts/ci.baseline.txt
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libnice/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL marked this pull request as ready for review February 15, 2022 08:13
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 16, 2022
@BillyONeal BillyONeal merged commit a116481 into microsoft:master Feb 16, 2022
@BillyONeal
Copy link
Member

Thanks for the update!

@Neumann-A Neumann-A deleted the update_libnice branch February 16, 2022 12:25
@ras0219-msft
Copy link
Contributor

The openssl pkgconfig dependency should have been fixed by #20831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants