[libsrtp] Add Exported CMake Targets for LibSRTP

[SE2Dev]

Describe the pull request

This pull request adds libsrtp-config.cmake to the libsrtp port, which allows users to do the following in CMake:

find_package(libsrtp REQUIRED)
# ...
target_link_libraries(main PRIVATE LibSRTP::srtp2)

Additionally, I've updated the deprecated helper function usage for the libsrtp port.

• What does your PR fix?

  Fixes the lack of CMake exports for libsrtp, and serves as a prerequisite for [libdatachannel] Fix LibDataChannel Broken SRTP Feature #20722.

• Which triplets are supported/not supported? Have you updated the CI baseline?

  unchanged, No

• Does your PR follow the maintainer guide?

  I believe so.

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[NancyLi1013]

Waiting for the response form upstream . cisco/libsrtp#573

[SE2Dev]

I should point out that at least part of this pull request will no longer be necessary if the changes to upstream are accepted. If that happens, I'll update this request and #20722 accordingly.

[LilyWangLL]

@SE2Dev The upstream PR has been merged. Could you please merge fix on upstream to this PR.

[SE2Dev]

@LilyWangLL Yes, although there's still no actual LibSRTP release that includes the merged changes. Should I selectively pull CMake files from a more current snapshot during the configuration process, or wait until there's a release that includes them?

[LilyWangLL]

@LilyWangLL Yes, although there's still no actual LibSRTP release that includes the merged changes. Should I selectively pull CMake files from a more current snapshot during the configuration process, or wait until there's a release that includes them?

You can download patch file from https://patch-diff.githubusercontent.com/raw/cisco/libsrtp/pull/573.diff at runtime by vcpkg_download_distfile. Then add it to PATCHES in vcpkg_from_github.

[SE2Dev]

I just pushed the requested changes. Since the path was never corrected in the original pull request before it was merged, I had to explicitly define the CONFIG_PATH for vcpkg_cmake_config_fixup.

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/libsrtp/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

I note upstream has already merged this.

[BillyONeal]

I'm not sure why CLA bot is unhappy; have you signed a Microsoft CLA before?

[BillyONeal]

It looks like CLA bot is wedged in many places :(

[SE2Dev]

It seems to be complaining about the fact that there's no license field in vcpkg.json. LibSRTP has its own license file in its repo; assuming I'm reading this correctly, the license field should be set to null, correct?

[BillyONeal]

That's a different bot; a suggestion but not a requirement. CLA is a requirement though. I have seen that wedged in other repos too; will keep you posted

[BillyONeal]

Tried merging to see if that kicks the bot

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/libsrtp/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/libsrtp/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

@SE2Dev Can you try manually visiting https://cla.opensource.microsoft.com/microsoft/vcpkg?pullRequest=20720 ?

[github-actions]

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/libsrtp/vcpkg.json

Valid values for the license field can be found in the documentation

[BillyONeal]

Closing and reopening the PR kicked the bot to be green :)

[SE2Dev]

Closing and reopening the PR kicked the bot to be green :)

Haha, nice! Apparently, I already signed the CLA at some point, so that shouldn't have been the problem.

[BillyONeal]

Thanks for the fix!