Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][libosip2] Use /Z7 rather than /Zi to avoid mspdbsrv crashes. #20758

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 14, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b7cff0d6f4aea4023e9f400726c5629a9032bf4a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index b74e960..41c69af 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3654,7 +3654,7 @@
     },
     "libosip2": {
       "baseline": "5.2.0",
-      "port-version": 0
+      "port-version": 1
     },
     "libosmium": {
       "baseline": "2.17.0",
diff --git a/versions/l-/libosip2.json b/versions/l-/libosip2.json
index 2363383..b3dd2aa 100644
--- a/versions/l-/libosip2.json
+++ b/versions/l-/libosip2.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "918421395ccee5a5d894f2720b4a779369eb0f97",
+      "version": "5.2.0",
+      "port-version": 1
+    },
     {
       "git-tree": "468e53f1a4709f0b1b2b83efe23a2a4bc9dd63c2",
       "version": "5.2.0",

@PhoebeHui PhoebeHui self-assigned this Oct 15, 2021
@JackBoosY JackBoosY changed the title [libosip2] Use /Z7 rather than /Zi to avoid mspdbsrv crashes. [vcpkg baseline][libosip2] Use /Z7 rather than /Zi to avoid mspdbsrv crashes. Oct 15, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Oct 15, 2021
@vicroms vicroms merged commit 3b08f52 into microsoft:master Oct 16, 2021
@BillyONeal BillyONeal deleted the libosip branch October 16, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants