[lief] Add new port for lief-project/LIEF #21213
Conversation
|
|
JonLiu1993
added
the
category:new-port
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/lief/portfile.cmake
|
@BehroozAbbassi ,Thanks for your pr, could you please take a look |
|
@BehroozAbbassi ,Thanks for your pr,could you please take a look: |
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
|
@JonLiu1993 Sorry for the delay :( I'm new to VCPKG contribution and just can't figure out how to fix this problem |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for lief but no changes to version or port version.
-- Version: 0.11.5
-- Old SHA: dd5f8edc575f08ba78998380c7e31e06da8e3023
-- New SHA: ae2b26b210826c46e6fafcec2b3c1f808a73d2dd
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
This is not a modification suggestion for you, I run the command "./vcpkg x-add-version lief --overwrite-version " and commit again |
|
I really confused, I used the if ("${VCPKG_LIBRARY_LINKAGE}" STREQUAL "static" )
if ("${VCPKG_CRT_LINKAGE}" STREQUAL "dynamic" )
vcpkg_fail_port_install(MESSAGE "${PORT} doesn't support static-md" ALWAYS)
endif()
endif()error message in |
|
@BehroozAbbassi, You can add lief:x64-windows-static-md=fail to https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt. |
|
@BehroozAbbassi ,Have you tried phoebe's review suggestions? |
|
@BehroozAbbassi ,Ping for response |
JonLiu1993
added
requires:author-response
and removed
info:reviewed
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
|
@BehroozAbbassi , I tested again the feature on my local machine, but failed: command: ./vcpkg install lief[*] F:\Feature-test\lief\vcpkg\buildtrees\lief\config-x86-windows-out.log |
hmm But this one is related to sanitizers, I've no idea how to use them with MSVC and CMAKE. I'm not sure if it's an error with cmake script or trying to use sanitizers on windows, maybe the author of library could help here, @romainthomas any idea? By the way I've this error even after I edit the # Set them OFF after the "vcpkg_check_features"
set(LIEF_ASAN OFF)
set(LIEF_LSAN OFF)
set(LIEF_TSAN OFF)
set(LIEF_USAN OFF)
|
|
@romainthomas, Could you please take a look? |
JonLiu1993
added
depends:upstream-changes
|
I'll check but the error seems weird |
|
Maybe you should first try with the latest release (0.12.0) that contains CMake refactoring (cc @ekilmer) |
I have a Draft PR for that here #22957 (initially forked from @BehroozAbbassi's branch). The main issue is mbedtls major version upgrade in vcpkg (more details in the OP of the PR). I also haven't merged the latest changes (mostly need to just double-check that non-default features still work/should be removed) from this branch. If the mbedtls version can't be updated for LIEF, then maybe LIEF will need to live in a separate registry along with mbedtls v3. I don't have time to work on anything this week, but anyone is free to fork my branch, make the necessary changes, and open a new PR, create a registry, whatever. Just let me know if #22957 should be closed in favor of something else! |
|
Just disable feature doc would be okay. |
JonLiu1993
added
depends:different-pr
|
@BehroozAbbassi, Is there any progress this pr？ |
JonLiu1993
removed
the
depends:different-pr
|
Draft this PR until it has any progress. |
ras0219-msft
dismissed stale reviews from JonLiu1993 and github-actions
via
2a0565e
|
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
Describe the pull request
Adds the lief library into the vcpkg ports
What does your PR fix?
Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes