-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[magnum-plugins] Update head features and bundled dependency #21307
Conversation
7d53484
to
3570ed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/magnum-plugins/portfile.cmake
3570ed5
to
af6c5d3
Compare
af6c5d3
to
6ee784e
Compare
Turned into a draft PR temporarily to coordinate with @mosra. If @NancyLi1013 confirms that head-only feature dependencies are acceptable, the bundled zstd handling can be removed upstream. |
6ee784e
to
1bfb52b
Compare
Have you tested this features? @pezcode |
I tested all the new and updated features with |
LGTM now, thanks for your PR @pezcode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This port should be updated to the latest commit instead. It removes the necessity for the extra logic around --head
which was never intended to be used this way.
@vicroms I'm not sure if I understand: the latest commit means |
Discussed with the rest of the team, this is fine since it acts like a no-op when a user requests unsupported features and doesn't add new dependencies for non-head users. |
This PR updates magnum-plugins with new features available when compiling with
--head
, along with an update to a bundled dependency required to compile.Note: the
spirvtoolsshaderconverter
feature is currently broken due to #18612Which triplets are supported/not supported? Have you updated the CI baseline?
There shouldn't be any changes compared to the current port version
Does your PR follow the maintainer guide?
To the best of my knowledge, yes 👀
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yessss