-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openssl] Revise vcpkg cmake wrapper #22701
Conversation
86de8a1
to
9eaba46
Compare
cc @Neumann-A @cenit for review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with my suggestion, thanks!
Hmmmmm
Whatever the cause is it certainly isn't this PR :) |
Awesome, thanks for addressing my CR and as always thanks for the PR! |
[openssl] Revise vcpkg cmake wrapper (microsoft#22701)
Cherry-picked from #22258.
What does your PR fix?
Fixes usage with CMake 3.4 (tested in [vcpkg-cmake-validate,vcpkg-maintainer-options] New ports #22258).
Sets the input variables used by CMake's Find module to the known locations instead of setting the ignore list.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes