Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openssl] Revise vcpkg cmake wrapper #22701

Merged
merged 9 commits into from
Feb 8, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jan 22, 2022

Cherry-picked from #22258.

  • What does your PR fix?

    Fixes usage with CMake 3.4 (tested in [vcpkg-cmake-validate,vcpkg-maintainer-options] New ports #22258).
    Sets the input variables used by CMake's Find module to the known locations instead of setting the ignore list.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 24, 2022
ports/openssl/vcpkg.json Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

cc @Neumann-A @cenit for review this PR.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 28, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with my suggestion, thanks!

ports/openssl/vcpkg-cmake-wrapper.cmake.in Outdated Show resolved Hide resolved
ports/openssl/vcpkg-cmake-wrapper.cmake.in Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

Hmmmmm

Error: vcpkg has crashed; no additional details are available.
The source line is D:\a_work\1\s\src\vcpkg\binarycaching.cpp(586)

https://github.com/microsoft/vcpkg-tool/blob/457b0309cefb58fae0dcb2e4c06de9bd7582967f/src/vcpkg/binarycaching.cpp#L587

Whatever the cause is it certainly isn't this PR :)

dg0yt added a commit to dg0yt/vcpkg that referenced this pull request Feb 6, 2022
@ras0219-msft ras0219-msft merged commit afb2279 into microsoft:master Feb 8, 2022
@ras0219-msft
Copy link
Contributor

Awesome, thanks for addressing my CR and as always thanks for the PR!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Feb 8, 2022
[openssl] Revise vcpkg cmake wrapper (microsoft#22701)
@dg0yt dg0yt deleted the openssl-wrapper branch February 8, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants