Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openssl] Remove vcpkg_fail_port_install. #22755

Merged

Conversation

BillyONeal
Copy link
Member

The only places this was being used were as morally asserts for the port itself, so I just deleted them. Also removed empty ports from ci.baseline.txt.

In support of #21502

The only places this was being used were as morally asserts for the port itself. Also removed empty ports from ci.baseline.txt.

In support of microsoft#21502
@BillyONeal BillyONeal added the info:internal This PR or Issue was filed by the vcpkg team. label Jan 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/openssl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@strega-nil-ms
Copy link
Contributor

@BillyONeal

Also removed empty ports from ci.baseline.txt.

I don't see this done; should it be?

@BillyONeal
Copy link
Member Author

@BillyONeal

Also removed empty ports from ci.baseline.txt.

I don't see this done; should it be?

https://github.com/microsoft/vcpkg/pull/22755/files#diff-9fcdd4a058d859ef3176f49bff8b5cb026f9fdfb2a35aaae36beaf6a9a0b1807L1026 ?

@strega-nil-ms
Copy link
Contributor

oh, got it, thanks!

@strega-nil-ms strega-nil-ms merged commit fb1df57 into microsoft:master Jan 24, 2022
@BillyONeal BillyONeal deleted the remove_fail_port_install_openssl branch January 24, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants