Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rs-core-lib/unicorn-lib] Remove rs-core-lib #22761

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

PhoebeHui
Copy link
Contributor

Changes:

  1. CaptainCrowbar/rs-core-lib repo has been removed. we can't find the source, so remove the port.
  2. unicorn-lib has removed rs-core-lib from dependency by CaptainCrowbar/unicorn-lib@1468193
  3. I didn't find any noticed that unicorn-lib depends on libiconv, remove it from dependency list.
  4. Update unicorn-lib to latest commit.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 24, 2022
@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Jan 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/unicorn-lib/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@PhoebeHui PhoebeHui marked this pull request as ready for review January 25, 2022 02:19
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 26, 2022
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Jan 26, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 1d28e4dea465549745b5e2a77024bf31c66e0d20 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 13122e0..652e2ba 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6116,6 +6116,10 @@
       "baseline": "1.1.4",
       "port-version": 1
     },
+    "rs-core-lib": {
+      "baseline": "2020-09-14",
+      "port-version": 1
+    },
     "rsasynccpp": {
       "baseline": "0.0.7",
       "port-version": 1

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 27, 2022
@ras0219-msft ras0219-msft merged commit 0921a9a into microsoft:master Jan 27, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants