[pixman] fix build on M1 macs #22854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/pixman/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
autoantwort
force-pushed
the
pixman-build-on-m1-macs2
branch
from
332d105
to
1580d56
Compare
JackBoosY
added
the
category:community-triplet
JackBoosY
approved these changes
Jan 29, 2022
|
I have created https://gitlab.freedesktop.org/pixman/pixman/-/issues/54 |
JackBoosY
added
depends:upstream-changes
|
Waiting for upstream reply. |
|
I think this is the right fix for vcpkg, because the user can instead directly add any desired cpu set flags to their global cflags. Therefore, there isn't a need for ad-hoc per-library detection. |
ras0219-msft
removed
the
depends:upstream-changes
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pixman checks the host and not the target cpu for cpu features