Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mpfr] Skip doc and examples #22859

Merged
merged 5 commits into from
Feb 16, 2022
Merged

[mpfr] Skip doc and examples #22859

merged 5 commits into from
Feb 16, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jan 30, 2022 •
edited

  • What does your PR fix?

    Don't build and install docs and examples (common practice in vcpkg). Drop texinfo dependency.
    Enable CI on osx and linux.
    Also drop msys2 gettext dependency - I didn't find how it is actually used.
    Updates license information.
    Fixes [mpfr] Build error #22671. Replaces [mpfr] Support Linux and OSX #22845. CC @JackBoosY @Neumann-A

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, yes.

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@dg0yt dg0yt mentioned this pull request Jan 31, 2022
Closed
@dg0yt
Copy link
Contributor Author

dg0yt commented Jan 31, 2022

Depends on #22872.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 3, 2022
@dg0yt dg0yt mentioned this pull request Feb 5, 2022
Merged
@dg0yt dg0yt marked this pull request as ready for review February 14, 2022 07:04
@FrankXie05
Copy link
Contributor

Need jack review @JackBoosY

JackBoosY
JackBoosY approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributor!

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Feb 16, 2022
@vicroms vicroms merged commit 55e666a into microsoft:master Feb 16, 2022
@dg0yt dg0yt deleted the mpfr branch February 17, 2022 05:15
@JackBoosY JackBoosY mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mpfr] Build error
4 participants
@dg0yt @FrankXie05 @JackBoosY @vicroms