Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gobject-introspection] Fix x86-windows build #22944

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[gobject-introspection] Fix x86-windows build #22944

merged 1 commit into from
Feb 9, 2022

Conversation

mkhon
Copy link
Contributor

@mkhon mkhon commented Feb 5, 2022

Describe the pull request

Fix x86-windows build (accidentally disabled when fixing build failures for the initial port PR)

  • What does your PR fix?

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gobject-introspection/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 6, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 8, 2022
@ras0219-msft
Copy link
Contributor

This LGTM, though the supports line continues to be extremely strange w.r.t. the actual code in the port.

@ras0219-msft ras0219-msft merged commit 69acc90 into microsoft:master Feb 9, 2022
@mkhon mkhon deleted the fix/gobject-introspection-x86 branch February 9, 2022 06:43
@mkhon
Copy link
Contributor Author

mkhon commented Feb 9, 2022

@ras0219-msft cross-building requires more work as gobject-introspection builds introspection data for itself.

When introspection data is being built, gobject-introspection uses host tools (host python) to run code generation, then compiles the executable (again, using python tooling) and executes it to dump introspection data.

This executable should be built for host (as it runs on host during the build), however the build environment at this point is configured by vcpkg to build for target.

Most likely gobject (host) introspection tools should reset the build environment to always build for host as these binaries are never executed on target. This requires more work. I will work on that in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants