[ftxui] update to 2.0.0 #22955
Merged
[ftxui] update to 2.0.0 #22955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ArthurSonzogni
force-pushed
the
master
branch
from
99cc990
to
79410fe
Compare
JackBoosY
added
the
category:port-update
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
suggested changes
Feb 6, 2022
- Switch to version-semver - Add version 2.0.0. Released 14 days ago: https://github.com/ArthurSonzogni/FTXUI/releases/tag/v2.0.0
ArthurSonzogni
force-pushed
the
master
branch
from
79410fe
to
c60127f
Compare
JackBoosY
reviewed
Feb 7, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ftxui", | |||
| "version-date": "2021-10-17", | |||
| "version-semver": "2.0.0", | |||
There was a problem hiding this comment.
Note to other reviewers: See ArthurSonzogni/FTXUI#207.
JackBoosY
approved these changes
Feb 7, 2022
JackBoosY
added
info:reviewed
ras0219-msft
approved these changes
Feb 8, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ftxui", | |||
| "version-date": "2021-10-17", | |||
| "version-semver": "2.0.0", | |||
| "port-version": 1, | |||
There was a problem hiding this comment.
Conventionally we remove the port-version (resetting it to 0) whenever the main version updates. However, this isn't a significant enough issue to warrant blocking the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ArthurSonzogni/FTXUI/releases/tag/v2.0.0
Describe the pull request
What does your PR fix?
version-semverinstead ofversion-dateWhich triplets are supported/not supported? Have you updated the CI baseline?
Similar to [ftxui] update to 0.11 #22293, uwp is not supported. I haven't touched
ci.baseline.txt. Should I? Not clear to me.Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/