[kf5archive] Fix feature control and license info #22963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
added
category:port-bug
|
All features are tested successfully in the following triplet:
|
|
This LGTM, thanks! |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Feb 8, 2022
[kf5archive] Fix zstd, feature control and license info (microsoft#22963)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Fixes control over optional features/dependencies. (The original patch was incomplete with regard to zstd, and it used wrong case for
zstdcmake config. Noticed while debugging the kf5archive build error with my zstd PR.)Make bzip2 an opt-out feature. (It is as optional as lzma and zstd, but it was included in the previous port version.)
The library source files are under a single license.
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes
CC @wrobelda